Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NEW Update rulesets #53

Merged
merged 1 commit into from
May 29, 2024
Merged

NEW Update rulesets #53

merged 1 commit into from
May 29, 2024

Conversation

emteknetnz
Copy link
Member

@emteknetnz emteknetnz force-pushed the pulls/main/branch-protection branch from e90ae59 to ceac308 Compare May 22, 2024 00:40
@emteknetnz emteknetnz closed this May 22, 2024
@emteknetnz emteknetnz reopened this May 22, 2024
@emteknetnz emteknetnz force-pushed the pulls/main/branch-protection branch 2 times, most recently from 9c89101 to 49cc2b7 Compare May 22, 2024 01:06
@emteknetnz emteknetnz mentioned this pull request May 22, 2024
Closed
@emteknetnz emteknetnz marked this pull request as ready for review May 22, 2024 01:07
@emteknetnz emteknetnz force-pushed the pulls/main/branch-protection branch 4 times, most recently from 391557f to 5cc282b Compare May 22, 2024 01:22
GuySartorelli
GuySartorelli requested changes May 29, 2024
View reviewed changes
run.php Outdated Show resolved Hide resolved
funcs_utils.php Show resolved Hide resolved
rulesets_command.php Outdated Show resolved Hide resolved
rulesets_command.php Show resolved Hide resolved
rulesets_command.php Show resolved Hide resolved
rulesets_command.php Show resolved Hide resolved
rulesets_command.php Show resolved Hide resolved
rulesets_command.php Outdated Show resolved Hide resolved
rulesets_command.php Show resolved Hide resolved
@emteknetnz emteknetnz force-pushed the pulls/main/branch-protection branch from 5cc282b to 0c5acc4 Compare May 29, 2024 01:01
@GuySartorelli
Copy link
Member

Just a couple of things above to consider. Up to you if you think changes are warranted or not.

GuySartorelli
GuySartorelli requested changes May 29, 2024
View reviewed changes
Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I thought I asked for this last time but it looks like I only thought about asking it: Please update the readme.

@emteknetnz emteknetnz force-pushed the pulls/main/branch-protection branch from 0c5acc4 to 9ecdfdf Compare May 29, 2024 03:04
@emteknetnz
Copy link
Member Author

Have updated readme

GuySartorelli
GuySartorelli approved these changes May 29, 2024
View reviewed changes
Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@GuySartorelli GuySartorelli merged commit 4efdcbe into silverstripe:main May 29, 2024
1 check passed
@GuySartorelli GuySartorelli deleted the pulls/main/branch-protection branch May 29, 2024 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GuySartorelli GuySartorelli GuySartorelli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@emteknetnz @GuySartorelli