FIX Cannot link an image in TinyMCE

silverstripe · Sep 5, 2023 · 94b84cf · 94b84cf
1 parent 714c773
commit 94b84cf
Show file tree

Hide file tree

Showing 5 changed files with 13 additions and 5 deletions.
diff --git a/client/dist/js/TinyMCE_sslink-email.js b/client/dist/js/TinyMCE_sslink-email.js
diff --git a/client/dist/js/TinyMCE_sslink-external.js b/client/dist/js/TinyMCE_sslink-external.js
diff --git a/client/dist/js/bundle.js b/client/dist/js/bundle.js
diff --git a/client/src/legacy/TinyMCE_sslink-email.js b/client/src/legacy/TinyMCE_sslink-email.js
@@ -60,7 +60,11 @@ jQuery.entwine('ss', ($) => {
       const handleInsert = (...args) => this.handleInsert(...args);
       const attrs = this.getOriginalAttributes();
       const selection = tinymce.activeEditor.selection;
-      const selectionContent = selection.getContent() || '';
+      let selectionContent = selection.getContent() || '';
+      if (!selectionContent) {
+        selectionContent = selection.getSel().toString();
+      }
+      selectionContent = selectionContent || '';
       const tagName = selection.getNode().tagName;
       const requireLinkText = tagName !== 'A' && selectionContent.trim() === '';
 

diff --git a/client/src/legacy/TinyMCE_sslink-external.js b/client/src/legacy/TinyMCE_sslink-external.js
@@ -55,7 +55,11 @@ jQuery.entwine('ss', ($) => {
       const handleInsert = (...args) => this.handleInsert(...args);
       const attrs = this.getOriginalAttributes();
       const selection = tinymce.activeEditor.selection;
-      const selectionContent = selection.getContent() || '';
+      let selectionContent = selection.getContent() || '';
+      if (!selectionContent) {
+        selectionContent = selection.getSel().toString();
+      }
+      selectionContent = selectionContent || '';
       const tagName = selection.getNode().tagName;
       const requireLinkText = tagName !== 'A' && selectionContent.trim() === '';