CMS 5: Cannot link an image in TinyMCE

[axllent]

Description

As of Silverstripe 5 it is not possible to link just an image within TinyMCE.

Steps to reproduce:

1. Insert image into editor
2. Select image, click link (any of "Page on this site", file, external URL etc)
3. Add/select link, click "Insert link" button

All attempts fail because of Link text is required.. If you fill in any link text (which you shouldn't have to anyway), that text replaces the image.

Behat tests

This fix involves multiple related pull requests - I have run a CI run with silverstripe/installer with all of the pull requests included to show that they work when they're all installed.

• CMS 4: https://github.com/creative-commoners/silverstripe-installer/actions/runs/6091324603
• CMS 5: https://github.com/creative-commoners/silverstripe-installer/actions/runs/6105659894

PR

CMS 4

• FIX Cannot link an image in TinyMCE #1570
• MNT Behat test for inserting link on image silverstripe-asset-admin#1393
• FIX Cannot link an image in TinyMCE #1571
• FIX Cannot link an image in TinyMCE silverstripe-cms#2880
• MNT Behat test for inserting link on image silverstripe-asset-admin#1394
• ENH Migrate image selection logic from asset-admin silverstripe-behat-extension#248
• FIX Allow wrapping an image in a link #1577
• FIX Allow wrapping an image in a link silverstripe-asset-admin#1397
• FIX Allow wrapping an image in a link silverstripe-cms#2883

CMS 5

• FIX Allow wrapping an image in a link #1579
• FIX Allow wrapping an image in a link silverstripe-asset-admin#1398
• FIX Allow wrapping an image in a link silverstripe-cms#2884
• ENH Migrate image selection logic from asset-admin silverstripe-behat-extension#249

[maxime-rainville]

I'm getting the same behaviour on CMS 4.

Interestingly, it works if you are trying to link to a file in CMS 4. In CMS5, it lets you create the link, but doesn't seem to save it.

[emteknetnz]

Linked PRs have been merged

[GuySartorelli]

Reopening to make sure the fix works for CMS 5 on merge up since tinyMCE changed a lot between majors

[emteknetnz]

Linked PRs have been merged