Merge pull request #558 from lekoala/patch-1

Don't make query if not needed

src/Shortcodes/FileLinkTracking.php

@@ -131,15 +131,22 @@ public function augmentSyncLinkTracking()
         $allFields = DataObject::getSchema()->fieldSpecs($this->owner);
         $linkedPages = [];
         $anyBroken = false;
+        $hasTrackedFields = false;
         foreach ($allFields as $field => $fieldSpec) {
             $fieldObj = $this->owner->dbObject($field);
             if ($fieldObj instanceof DBHTMLText) {
+                $hasTrackedFields = true;
                 // Merge links in this field with global list.
                 $linksInField = $this->trackLinksInField($field, $anyBroken);
                 $linkedPages = array_merge($linkedPages, $linksInField);
             }
         }
 
+        // We cannot rely on linkedPages being empty, because we need to remove them if there was any
+        if (!$hasTrackedFields) {
+            return;
+        }
+
         // Soft support for HasBrokenFile db field (e.g. SiteTree)
         if ($this->owner->hasField('HasBrokenFile')) {
             $this->owner->HasBrokenFile = $anyBroken;