Merge pull request #560 from lekoala/patch-2

AssetControlExtension should run less queries

src/AssetControlExtension.php

@@ -52,6 +52,10 @@ class AssetControlExtension extends DataExtension
      */
     public function onAfterDelete()
     {
+        if (!$this->hasAssets()) {
+            return;
+        }
+
         // Prepare blank manipulation
         $manipulations = new AssetManipulationList();
 
@@ -71,6 +75,10 @@ public function onAfterDelete()
      */
     public function onBeforeWrite()
     {
+        if (!$this->hasAssets()) {
+            return;
+        }
+
         // Prepare blank manipulation
         $manipulations = new AssetManipulationList();
 
@@ -209,6 +217,18 @@ protected function addAssetsFromRecord(AssetManipulationList $manipulation, Data
         }
     }
 
+    private function hasAssets(): bool
+    {
+        $fields = DataObject::getSchema()->fieldSpecs($this->owner);
+        foreach ($fields as $field => $db) {
+            $fieldObj = $this->owner->dbObject($field);
+            if ($fieldObj instanceof DBFile) {
+                return true;
+            }
+        }
+        return false;
+    }
+
     /**
      * Return a list of all tuples attached to this dataobject
      * Note: Variants are excluded