FIX getCachedMarkup returns NULL instead of string if file doesn't exist

silverstripe · Jul 11, 2023 · bd9ebb7 · bd9ebb7
1 parent 7db8cde
commit bd9ebb7
Show file tree

Hide file tree

Showing 2 changed files with 39 additions and 2 deletions.
diff --git a/src/Shortcodes/FileShortcodeProvider.php b/src/Shortcodes/FileShortcodeProvider.php
@@ -139,11 +139,15 @@ public static function handle_shortcode($arguments, $content, $parser, $shortcod
     protected static function getCachedMarkup($cache, $cacheKey, $arguments): string
     {
         $item = $cache->get($cacheKey);
-        if ($item && !empty($item['filename'])) {
+        $assetStore = Injector::inst()->get(AssetStore::class);
+        if ($item
+            && !empty($item['filename'])
+            && $assetStore->exists($item['filename'], $item['hash'])
+            && $item['markup']) {
             // Initiate a protected asset grant if necessary
             $allowSessionGrant = static::getGrant(null, $arguments);
             if ($allowSessionGrant) {
-                Injector::inst()->get(AssetStore::class)->grant($item['filename'], $item['hash']);
+                $assetStore->grant($item['filename'], $item['hash']);
                 return $item['markup'];
             }
         }

diff --git a/tests/php/Shortcodes/FileShortcodeProviderTest.php b/tests/php/Shortcodes/FileShortcodeProviderTest.php
@@ -149,4 +149,37 @@ public function testOnlyGrantsAccessWhenConfiguredTo()
         $parser->parse(sprintf('[file_link,id=%d]', $testFile->ID));
         $this->assertFalse($assetStore->isGranted($testFile));
     }
+
+    public function testMarkupHasStringValue()
+    {
+        $testFile = $this->objFromFixture(File::class, 'asdf');
+        $testFileID = $testFile->ID;
+        $tuple = $testFile->File->getValue();
+
+        $assetStore = Injector::inst()->get(AssetStore::class);
+
+        $parser = new ShortcodeParser();
+        $parser->register('file_link', [FileShortcodeProvider::class, 'handle_shortcode']);
+
+        FileShortcodeProvider::config()->set('allow_session_grant', true);
+
+        $fileShortcode = sprintf('[file_link,id=%d]', $testFileID);
+        $this->assertEquals(
+            $testFile->Link(),
+            $parser->parse(sprintf('[file_link,id=%d]', $testFileID)),
+            'Test that shortcode with existing file ID is parsed.'
+        );
+
+        $testFile->deleteFile();
+        $this->assertFalse(
+            $assetStore->exists($tuple['Filename'], $tuple['Hash']),
+            'Test that file was removed from Asset store.'
+        );
+
+        $this->assertEquals(
+            '',
+            $parser->parse(sprintf('[file_link,id=%d]', $testFileID)),
+            'Test that shortcode with invalid file ID is not parsed.'
+        );
+    }
 }