API Strong typing for the view layer

silverstripe · Aug 25, 2024 · fdb242d · fdb242d
1 parent 85dd0e1
commit fdb242d
Show file tree

Hide file tree

Showing 3 changed files with 69 additions and 117 deletions.
diff --git a/src/File.php b/src/File.php
@@ -299,10 +299,8 @@ public static function get_shortcodes()
      *
      * Use $file->isInDB() to only check for a DB record
      * Use $file->File->exists() to only check if the asset exists
-     *
-     * @return bool
      */
-    public function exists()
+    public function exists(): bool
     {
         return parent::exists() && $this->File->exists();
     }
@@ -1316,10 +1314,8 @@ public function getVariant()
 
     /**
      * Return a html5 tag of the appropriate for this file (normally img or a)
-     *
-     * @return string
      */
-    public function forTemplate()
+    public function forTemplate(): string
     {
         return $this->getTag() ?: '';
     }

diff --git a/src/Folder.php b/src/Folder.php
@@ -40,7 +40,7 @@ class Folder extends File
 
     private static $table_name = 'Folder';
 
-    public function exists()
+    public function exists(): bool
     {
         return $this->isInDB();
     }