Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve logging and error reporting of TagToShortcode task #310

Open
maxime-rainville opened this issue Aug 8, 2019 · 1 comment
Open

Comments

@maxime-rainville
Copy link
Contributor

Description

The TagToShortCode task doesn't currently provide much feedback if a shortcode is not converted.

If a specific short code conversation fails, the entire task fails.

We should log a warning when an a file we expect should be found can not be found. And we should wrap the function that tries to find expression to converts in each HTMLText value in a try-catch so the task is more resilient.

@sminnee
Copy link
Member

sminnee commented Aug 19, 2019

This will be easier if the task provides a logger object.

I see that with MigrateFileTask we've done this, but I wonder if adding silverstripe/silverstripe-framework#9183 to 4.5 core would make this kind of stuff slightly less hacky (or at least we have 1 hack, as opposed to a hack-per-BuildTask)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants