Don't make query if not needed #558
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
setByIDList will make a query even though there are no DBHTMLText for this DataObject Checking the presence of these fields allow to return early and prevent the needless query
|
@michalkleiner any other wishes for this PR ? |
michalkleiner
approved these changes
Jul 11, 2023
|
Arguably this is an enhancement and shouldn't be targeting CMS 4 - but given the very low risk of regression it's probably fine. |
GuySartorelli
requested changes
Aug 3, 2023
|
@GuySartorelli do you also apply this to the ss5 version or do i need to make a pr for that as well? |
|
@lekoala it'll get merged up, eventually. We're working on getting merge ups to be automated but for now they're just done ad hoc. If you need this immediately let me know and I'll make a point to do merge ups sooner rather than later. |
|
@GuySartorelli i'm in the upgrade process to ss5 for my main client and that should go to production at the end of the summer, so if it's in a month or so that works for me :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
setByIDList will make a query even though there are no DBHTMLText for this DataObject
Checking the presence of these fields allow to return early and prevent the needless query
Fixes #557