Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ENH Use updated FormField::validate() signature #340

Open
wants to merge 1 commit into
base: 3
Choose a base branch
from
Open

ENH Use updated FormField::validate() signature #340

wants to merge 1 commit into from

Conversation

emteknetnz
Copy link
Member

@emteknetnz emteknetnz mentioned this pull request Oct 31, 2024
Closed
2 tasks
@emteknetnz emteknetnz marked this pull request as draft October 31, 2024 23:36
@emteknetnz emteknetnz changed the title ENH Use FieldValidator for FormFields API Use updated FormField::validate() signature Nov 13, 2024
@emteknetnz emteknetnz force-pushed the pulls/3/form-field-valid branch from 28df29b to 3abd1bf Compare November 13, 2024 00:53
@emteknetnz emteknetnz marked this pull request as ready for review November 14, 2024 22:07
GuySartorelli
GuySartorelli requested changes Nov 20, 2024
View reviewed changes
Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The commit message doesn't match up with the code change - please update the commit message to be ENH

@GuySartorelli
Copy link
Member

Or just close since we're not supporting this module going forward.

@emteknetnz emteknetnz force-pushed the pulls/3/form-field-valid branch from 3abd1bf to ffb7698 Compare November 21, 2024 00:45
@emteknetnz emteknetnz changed the title API Use updated FormField::validate() signature ENH Use updated FormField::validate() signature Nov 21, 2024
@emteknetnz emteknetnz force-pushed the pulls/3/form-field-valid branch from ffb7698 to 5583589 Compare November 21, 2024 05:03
@emteknetnz
Copy link
Member Author

Updated

GuySartorelli
GuySartorelli approved these changes Nov 25, 2024
View reviewed changes
Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, will merge when all PRs are ready

@emteknetnz emteknetnz force-pushed the pulls/3/form-field-valid branch from 5583589 to f8ef223 Compare November 26, 2024 05:59
@emteknetnz emteknetnz force-pushed the pulls/3/form-field-valid branch from f8ef223 to 120e9f9 Compare November 27, 2024 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GuySartorelli GuySartorelli GuySartorelli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@emteknetnz @GuySartorelli