Skip to content

Commit

Permalink
MNT Remove TODO comments
Browse files Browse the repository at this point in the history
  • Loading branch information
Sabina Talipova committed Oct 11, 2023
1 parent 58a2d58 commit 1ff55f8
Show file tree
Hide file tree
Showing 10 changed files with 5 additions and 18 deletions.
2 changes: 0 additions & 2 deletions code/Controllers/CMSMain.php
Original file line number Diff line number Diff line change
Expand Up @@ -80,8 +80,6 @@
* This class creates a 2-frame layout - left-tree and right-form - to sit beneath the main
* admin menu.
*
* @todo Create some base classes to contain the generic functionality that will be replicated.
*
* @mixin LeftAndMainPageIconsExtension
*/
class CMSMain extends LeftAndMain implements CurrentPageIdentifier, PermissionProvider, Flushable, MemberCacheFlusher
Expand Down
3 changes: 0 additions & 3 deletions code/Controllers/ContentController.php
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,6 @@
* Subclasses of ContentController are generally instantiated by ModelAsController; this will create
* a controller based on the URLSegment action variable, by looking in the SiteTree table.
*
* @todo Can this be used for anything other than SiteTree controllers?
*/
class ContentController extends Controller
{
Expand Down Expand Up @@ -303,8 +302,6 @@ public function Menu($level)
/**
* Returns the default log-in form.
*
* @todo Check if here should be returned just the default log-in form or
* all available log-in forms (also OpenID...)
* @return \SilverStripe\Security\MemberAuthenticator\MemberLoginForm
*/
public function LoginForm()
Expand Down
1 change: 0 additions & 1 deletion code/Model/SiteTree.php
Original file line number Diff line number Diff line change
Expand Up @@ -1958,7 +1958,6 @@ public function getLiveURLSegment()
*/
public function BackLinkTracking()
{
// @todo - Implement PolymorphicManyManyList to replace this
$list = ArrayList::create();

$siteTreelinkTable = SiteTreeLink::singleton()->baseTable();
Expand Down
2 changes: 1 addition & 1 deletion code/Reports/BrokenFilesReport.php
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ public function columns()
{
return [
"Title" => [
"title" => "Title", // todo: use NestedTitle(2)
"title" => "Title",
"link" => true,
],
];
Expand Down
2 changes: 1 addition & 1 deletion code/Reports/BrokenRedirectorPagesReport.php
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ public function columns()
{
return [
"Title" => [
"title" => "Title", // todo: use NestedTitle(2)
"title" => "Title",
"link" => true,
],
];
Expand Down
2 changes: 1 addition & 1 deletion code/Reports/BrokenVirtualPagesReport.php
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ public function columns()
{
return [
"Title" => [
"title" => "Title", // todo: use NestedTitle(2)
"title" => "Title",
"link" => true,
],
];
Expand Down
2 changes: 1 addition & 1 deletion code/Reports/EmptyPagesReport.php
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ public function columns()
{
return [
"Title" => [
"title" => "Title", // todo: use NestedTitle(2)
"title" => "Title",
"link" => true,
],
];
Expand Down
2 changes: 1 addition & 1 deletion code/Reports/RecentlyEditedReport.php
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ public function columns()
{
return [
"Title" => [
"title" => "Title", // todo: use NestedTitle(2)
"title" => "Title",
"link" => true,
],
];
Expand Down
4 changes: 0 additions & 4 deletions tests/php/Model/SiteTreePermissionsTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -12,10 +12,6 @@
use SilverStripe\Subsites\Extensions\SiteTreeSubsites;
use SilverStripe\Versioned\Versioned;

/**
* @todo Test canAddChildren()
* @todo Test canCreate()
*/
class SiteTreePermissionsTest extends FunctionalTest
{
protected static $fixture_file = "SiteTreePermissionsTest.yml";
Expand Down
3 changes: 0 additions & 3 deletions tests/php/Search/ZZZSearchFormTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -21,9 +21,6 @@
use TractorCow\Fluent\Extension\FluentSiteTreeExtension;

/**
* @todo Fix unpublished pages check in testPublishedPagesMatchedByTitle()
* @todo All tests run on unpublished pages at the moment, due to the searchform not distinguishing between them
*
* Because this manipulates the test database in severe ways, I've renamed the test to force it to run last...
*/
class ZZZSearchFormTest extends FunctionalTest
Expand Down

0 comments on commit 1ff55f8

Please sign in to comment.