Scaffold fields for SiteTree

[maxime-rainville]

When you define DB fields for a regular DataObject, getCMSFields will scaffold them for you.

SiteTree doesn't do that. So you have to manually created all the fields. We should remedy this.

Maybe we provide an option to disable that to minimise upgrade pain.

Note

• We made some DataObjects auto-scaffoldable with more sensible form fields in Autoscaffold DataObject in CMS 6 .github#262. Some of that might need to be adjusted or taken into account when actioning this card.

Acceptance Criteria

• SiteTree::getCMSFields() calls parent::getCMSFields() (which will autoscaffold fields)
• Custom logic in SiteTree::getCMSFields() is wrapped in $this->beforeUpdateCMSFields() so extension hooks are called appropriately
• The changelog makes it very clear that this change is happening, and that developers should check their implementations of getCMSFields() in their page classes to ensure things are working the way they expect (e.g. autscaffolded has_many and many_many relations may be giving them new tabs that weren't there before)
• All native Page type are revisited to validate that:
  • the FormFields are still displayed in the same tab as they were before
  • to remove redundant scaffolding logic
  • no new form fields are added to existing pages.

CMS 5 PRs

• NEW Make CMSFields scaffolding configurable, plus new options silverstripe-framework#11328
• NEW Add new method TabSet::changeTabOrder(). silverstripe-framework#11329
• DOC Document new tab order and form scaffolder changes developer-docs#549

CMS 6 PRs

kitchen sink CI run
recipe-reporting failure is expected because we're forking framework for that CI run.
Compare with normal CMS 6 run for other failures.

• ENH Various changes to support SiteTree form field scaffolding silverstripe-framework#11327
• NEW Use autoscaffolding for SiteTree CMS fields #2983
• FIX Update CMS fields now that they're being scaffolded silverstripe-userforms#1315
• FIX Update CMS fields now that they're being scaffolded silverstripe-blog#775
• FIX Update CMS fields now that they're being scaffolded silverstripe-subsites#589
• FIX Update CMS fields now that they're being scaffolded silverstripe-registry#103
• FIX Update CMS fields now that they're being scaffolded silverstripe-iframe#95
• FIX Update CMS fields now that they're being scaffolded silverstripe-sharedraftcontent#248
• FIX Update CMS fields now that they're being scaffolded silverstripe-versionfeed#117
• FIX Update CMS fields now that they're being scaffolded silverstripe-contentreview#248
• FIX Update CMS fields now that they're being scaffolded silverstripe-errorpage#117
• FIX Update CMS fields now that they're being scaffolded symbiote/silverstripe-advancedworkflow#545
• FIX Update CMS fields now that they're being scaffolded silverstripe-frameworktest#198
• FIX Explicitly don't autoscaffold ElementalArea silverstripe-elemental#1231
• DOC Document SiteTree form field scaffolding developer-docs#550