Ampersand (&) in alt-attribute is escaped over and over again

[baukezwaan]

Affected Version

Silverstripe 4.0 - 4.11

Description

When working in the CMS editor, the use of an ampersand is properly escaped by TinyMCE upon usage (via source or via inserting an image). However, when saving the page, the HTML is parsed by Silverstripe and escaped again. This results in over-and-over escaping the ampersand.

So instead of:

<p><img class="leftAlone ss-htmleditorfield-file image" title="Batman &amp; Robin" src="/assets/dummy.jpg" width="600" height="433" data-id="2" data-shortcode="image" /></p>

This results in (after hitting Save / Publish several times)

<p><img class="leftAlone ss-htmleditorfield-file image" title="Batman &amp;amp;amp;amp;amp;amp;amp;amp;amp;amp;amp; Robin" src="/assets/dummy.jpg" width="600" height="433" data-id="2" data-shortcode="image" /></p>

Steps to Reproduce

• Use a clean install of Silverstripe CMS
• Open homepage in CMS
• Insert an Image and set a alt-text (or title attribute) to a string with an ampersand
• Check source code before saving (see alt="Batman & Robin")
• Hit Save or Publish
• Check source code again and see alt="Batman & Robin"

PRs

• FIX Multi HTML entities in image shortcodes silverstripe-assets#565
• FIX Multi HTML entities in short codes #10903
• MNT Behat test to test special characters in shortcode silverstripe-asset-admin#1376
• FIX Double encoding image shortcode attributes silverstripe-assets#567

[GuySartorelli]

PRs merged. Github Actions will automatically tag patches once CI has finished running on the branch.