Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove DatabaseAdmin remapping functionality #11362

Closed
3 tasks
emteknetnz opened this issue Sep 5, 2024 · 3 comments
Closed
3 tasks

Remove DatabaseAdmin remapping functionality #11362

emteknetnz opened this issue Sep 5, 2024 · 3 comments

Comments

@emteknetnz
Copy link
Member

emteknetnz commented Sep 5, 2024 •
edited
Loading

DatabaseAdmin has some old code that supports migrating databases from CMS 3. It should be removed:

  • private static $classname_value_remapping
  • protected function getClassNameRemappingFields()
  • protected function migrateClassNames()

Acceptance criteria

  • Deprecate code in CMS 5
  • Remove code in CMS 6
  • Mention briefly in CMS 5.4.0 changelog
@emteknetnz emteknetnz mentioned this issue Sep 5, 2024
Merged
@emteknetnz emteknetnz transferred this issue from silverstripe/.github Sep 5, 2024
@GuySartorelli
Copy link
Member

Blocking this on #11341 which is moving that code around a bit.

@GuySartorelli
Copy link
Member

Actually I don't think we should remove that. It's useful for migrating data when updating classnames at any point in a project's lifetime and isn't limited to the 3->4 upgrade.

@emteknetnz
Copy link
Member Author

OK will close, keep code as is

@emteknetnz emteknetnz mentioned this issue Sep 11, 2024
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@emteknetnz @GuySartorelli