Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update DataExtension class to match all extension points #4376

Closed
wernerkrauss opened this issue Jul 7, 2015 · 5 comments
Closed

update DataExtension class to match all extension points #4376

wernerkrauss opened this issue Jul 7, 2015 · 5 comments
Labels
affects/v4 complexity/low impact/low type/docs

Comments

@wernerkrauss
Copy link
Contributor

There are some undocumented extensions points in DataObject that are quite unknown, cause DataExtension class doesn't reflect it. E.g. updateSearchableFields() (see http://api.silverstripe.org/3.1/source-class-DataObject.html#3260)
@dhensby
Copy link
Contributor

dhensby commented Jul 7, 2015

This sounds more like a docs problem than a code one. Would you mind submitting a PR?

@wernerkrauss
Copy link
Contributor Author

You mean a PR for DataExtension? Then it will be in API docs automatically. Yes, i can do this. Can you assign the ticket to me?

@dhensby
Copy link
Contributor

dhensby commented Jul 13, 2015

yep, for DataExtension.

I can only assign to people on the core team, I'm afraid

@kinglozzer kinglozzer assigned kinglozzer and unassigned kinglozzer Jul 27, 2015
@robbieaverill
Copy link
Contributor

There are still a bunch of methods without PHPDocs in DataExtension in SS4 e.g. onBeforeWrite and onAfterWrite, re-assigning labels

wernerkrauss added a commit to wernerkrauss/silverstripe-framework that referenced this issue Nov 10, 2018
@wernerkrauss
DataExtension: add missing hooks, improve docblocks (WIP)
ff26f5d 
See silverstripe#4376
wernerkrauss added a commit to wernerkrauss/silverstripe-framework that referenced this issue Nov 10, 2018
@wernerkrauss
DataExtension: add missing hooks, improve docblocks (WIP)
c390970 
See silverstripe#4376
TylahBucktonPereira added a commit to TylahBucktonPereira/silverstripe-framework that referenced this issue Jan 15, 2019
@TylahBucktonPereira
FIX: Fixes silverstripe#4376 partially added missing doc blocks.
d82c6d2
@TylahBucktonPereira TylahBucktonPereira mentioned this issue Jan 16, 2019
Closed
@jakxnz jakxnz mentioned this issue Jun 11, 2020
Merged
@GuySartorelli
Copy link
Member

Closed in favour of #11050

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
affects/v4 complexity/low impact/low type/docs
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
7 participants
@sminnee @dhensby @wernerkrauss @kinglozzer @emteknetnz @robbieaverill @GuySartorelli