Merge pull request #177 from creative-commoners/pulls/2/protect-hooks

API Set extension hook implementation visibility to protected
silverstripe · May 21, 2024 · f87f2c2 · f87f2c2
2 parents 2488992 + 62d9fbc
commit f87f2c2
Show file tree

Hide file tree

Showing 6 changed files with 7 additions and 7 deletions.
diff --git a/code/FrameworkTestRole.php b/code/FrameworkTestRole.php
@@ -16,7 +16,7 @@ class FrameworkTestRole extends DataExtension
         'FavouritePage' => 'SilverStripe\\CMS\\Model\\SiteTree',
     );
 
-    public function updateCMSFields(FieldList $fields)
+    protected function updateCMSFields(FieldList $fields)
     {
         $fields->addFieldToTab(
             'Root.Main',

diff --git a/code/elemental/ElementContentExtension.php b/code/elemental/ElementContentExtension.php
@@ -40,12 +40,12 @@ public function validate(ValidationResult $result)
         }
     }
 
-    public function updateCMSCompositeValidator(CompositeValidator $compositeValidator)
+    protected function updateCMSCompositeValidator(CompositeValidator $compositeValidator)
     {
         $compositeValidator->addValidator(new RequiredFields(['Title', 'MyPageID', 'MyFile']));
     }
 
-    public function updateCMSFields(FieldList $fields)
+    protected function updateCMSFields(FieldList $fields)
     {
         $fields->removeByName('HTML');
         $fields->addFieldToTab('Root.Main', TextField::create('MyField', 'My Field'));

diff --git a/code/elemental/NumericFieldExtension.php b/code/elemental/NumericFieldExtension.php
@@ -10,7 +10,7 @@
  */
 class NumericFieldExtension extends Extension
 {
-    public function updateValidationResult($result, $validator)
+    protected function updateValidationResult($result, $validator)
     {
         if ($this->owner->Value() == 1) {
             $validator->validationError($this->owner->getName(), 'This field cannot be 1');

diff --git a/code/linkfield/Extensions/CompanyExtension.php b/code/linkfield/Extensions/CompanyExtension.php
@@ -34,7 +34,7 @@ class CompanyExtension extends Extension
         'ManyCompanyWebSiteLink',
     ];
 
-    public function updateCMSFields(FieldList $fields)
+    protected function updateCMSFields(FieldList $fields)
     {
         $fields->removeByName(['CompanyWebSiteLinkID', 'ManyCompanyWebSiteLinkID']);
 

diff --git a/code/linkfield/Extensions/ElementContentExtension.php b/code/linkfield/Extensions/ElementContentExtension.php
@@ -37,7 +37,7 @@ class ElementContentExtension extends Extension
         'ManyLinks',
     ];
 
-    public function updateCMSFields($fields)
+    protected function updateCMSFields($fields)
     {
         $fields->removeByName(['OneLinkID', 'ManyLinks']);
         $fields->addFieldsToTab(

diff --git a/code/linkfield/Extensions/LinkPageExtension.php b/code/linkfield/Extensions/LinkPageExtension.php
@@ -36,7 +36,7 @@ class LinkPageExtension extends Extension
         'HasManyLinks',
     ];
 
-    public function updateCMSFields(FieldList $fields)
+    protected function updateCMSFields(FieldList $fields)
     {
         $fields->removeByName(['Content', 'HasOneLinkID', 'HasManyLinksID']);