DEP Limit PHP support for CMS 6 (#598)

silverstripe · Aug 22, 2024 · 69ed9a0 · 69ed9a0
1 parent c783f5c
commit 69ed9a0
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 9 deletions.
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -11,15 +11,15 @@ jobs:
     uses: silverstripe/gha-ci/.github/workflows/ci.yml@v1
     with:
       extra_jobs: |
-        - php: 8.1
+        - php: 8.3
           endtoend: true
           endtoend_suite: asset-admin
           endtoend_config: vendor/silverstripe/asset-admin/behat.yml
-        - php: 8.1
+        - php: 8.3
           endtoend: true
           endtoend_suite: versioned-admin
           endtoend_config: vendor/silverstripe/versioned-admin/behat.yml
-        - php: 8.1
+        - php: 8.3
           endtoend: true
           endtoend_suite: silverstripe-elemental
           endtoend_config: vendor/dnadesign/silverstripe-elemental/behat.yml
diff --git a/composer.json b/composer.json
@@ -4,7 +4,7 @@
     "type": "silverstripe-vendormodule",
     "license": "BSD-3-Clause",
     "require": {
-        "php": "^8.1",
+        "php": "^8.3",
         "silverstripe/framework": "^6",
         "silverstripe/vendor-plugin": "^2",
         "webonyx/graphql-php": "^15.0.1",

diff --git a/tests/Schema/IntegrationTest.php b/tests/Schema/IntegrationTest.php
@@ -43,7 +43,7 @@
 use GraphQL\Validator\Rules\QueryComplexity;
 use GraphQL\Validator\Rules\QueryDepth;
 use GraphQL\Validator\ValidationContext;
-use ReflectionProperty;
+use ReflectionClass;
 
 class IntegrationTest extends SapphireTest
 {
@@ -1688,11 +1688,10 @@ public function testGlobalRuleNotRemoved()
 
     private function removeDocumentValidatorRule(string $ruleName): void
     {
-        $reflectionRules = new ReflectionProperty(DocumentValidator::class, 'rules');
-        $reflectionRules->setAccessible(true);
-        $rules = $reflectionRules->getValue();
+        $reflectionValidator = new ReflectionClass(DocumentValidator::class);
+        $rules = $reflectionValidator->getStaticPropertyValue('rules');
         unset($rules[$ruleName]);
-        $reflectionRules->setValue($rules);
+        $reflectionValidator->setStaticPropertyValue('rules', $rules);
     }
 
     private function createProviderForComplexityOrDepth(int $limit): array