Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Empty translation strings cause blank output #114

Open
micschk opened this issue Jul 11, 2022 · 1 comment
Open

Empty translation strings cause blank output #114

micschk opened this issue Jul 11, 2022 · 1 comment

Comments

@micschk
Copy link

micschk commented Jul 11, 2022

Not sure how string translations usually get filled with placeholder values. I'd guess translations should hold the english value untill they're translated? In this module it seems translation strings got added to existing Yaml translation files, but the translation values were left empty. This causes fields/titles etc to be blank instead of falling back to their english translation.

Eg "what's that interesting title-less queuedjob being added there?"
(spoiler-alert it's the SilverStripe\SessionManager\Jobs\GarbageCollectionJob, in Dutch called '')

Screenshot 2022-07-11 at 10 55 22

Screenshot 2022-07-11 at 10 58 07

NOTE: some of these blank values have in the mean time been filled in the repo but there's still duplicate files for nl (nl_NL), both with some empty values in them it seems.

micschk added a commit to micschk/silverstripe-session-manager that referenced this issue Jul 11, 2022
Strings don't seem to be used in LoginSessionController anymore.
Other empty strings have all been filled so silverstripe#114 can probably be closed.
@GuySartorelli
Copy link
Member

I'd guess translations should hold the english value untill they're translated?

Yes, that's normally how this would be done. I don't know why they're showing empty...

Do you know if this is a regression that has been introduced recently, or if it was always like this?

In either case, translation strings are handled via transifex. If you update the strings there (to either the correct translated string, or to be the same as the english string) then it will get updated the next time we do a release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants