API Use new RememberLoginHash::onAfterRenewSession extension point #214
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This extension point is triggered at the same step as the now-removed
onAfterRenewToken
extension point, which was replaced to reflect that the token is no longer rotated when a session renewal is triggered.I've also added some comments to more clearly articulate the session identifier replacement logic - I considered pulling this out instead, but for efficiency it makes sense to retain.
Co-dependent on related framework PR: silverstripe/silverstripe-framework#11355
Manual testing steps
Checkout this PR along with the Framework PR and validate that remember me functionality is intact.
Issues
Pull request checklist