BUG Only allow the owner of a LoginSession to view/delete it #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
emteknetnz
requested changes
Apr 15, 2021
2 tasks
emteknetnz
reviewed
Apr 21, 2021
emteknetnz
reviewed
Apr 21, 2021
emteknetnz
requested changes
Apr 21, 2021
|
Found an issue during manual testing, noticed that a non-admin user isn't able to revoke their own sessions. My test user was in the group "Content authors". When that user attempted to revoke a session I see a red toast "Could not log out of session. Try again later" |
|
I don't think it's a CanView/CanDelete problem. Checked out the 1 branch and got the same result. The problem is probably that non-admin users are not allowed to interact with the |
6 tasks
|
Have agreed to split of non-admin revoking as a separate issue #67 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #57