Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API Set extension hook implementation visibility to protected #89

Merged
merged 1 commit into from
May 21, 2024
Merged

API Set extension hook implementation visibility to protected #89

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions docs/en/developer-documentation.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ For instance, in order to add a new Page field to the report you could add an ex
use SilverStripe\SiteWideContentReport\SiteWideContentReport;

class MyReportExtension extends Extension {
public function updateColumns($itemType, &$columns) {
protected function updateColumns($itemType, &$columns) {
if(itemType !== 'Pages') {
return;
}
Expand Down Expand Up @@ -68,7 +68,7 @@ use SilverStripe\GridfieldQueuedExport\Forms\GridFieldQueuedExportButton;

class SitewideContentReportQueuedExportExtension extends Extension
{
public function updateExportButton(GridFieldComponent &$exportButton)
protected function updateExportButton(GridFieldComponent &$exportButton)
{
$exportButton = new GridFieldQueuedExportButton('buttons-after-left');
}
Expand Down
2 changes: 1 addition & 1 deletion src/Model/SitewideContentReview.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ class SitewideContentReview extends Extension
* @param array $columns Columns
* @return mixed
*/
public function updateColumns($itemType, &$columns)
protected function updateColumns($itemType, &$columns)
{
if ($itemType !== 'Pages') {
return;
Expand Down
4 changes: 2 additions & 2 deletions src/Model/SitewideContentSubsites.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ class SitewideContentSubsites extends Extension
* @param string $itemType (i.e 'Pages' or 'Files')
* @param array $columns Columns
*/
public function updateColumns($itemType, &$columns)
protected function updateColumns($itemType, &$columns)
{
// Skip single subsite setups
if (!Subsite::get()->count()) {
Expand Down Expand Up @@ -57,7 +57,7 @@ public function updateColumns($itemType, &$columns)
* @param $record
* @param $attributes
*/
public function updateRowAttributes($total, $index, $record, &$attributes)
protected function updateRowAttributes($total, $index, $record, &$attributes)
{
$attributes['data-subsite-id'] = $record->SubsiteID;
}
Expand Down
2 changes: 1 addition & 1 deletion src/Model/SitewideContentTaxonomy.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ class SitewideContentTaxonomy extends Extension
* @param string $itemType (i.e 'Pages' or 'Files')
* @param array $columns Columns
*/
public function updateColumns($itemType, &$columns)
protected function updateColumns($itemType, &$columns)
{
if ($itemType !== 'Pages') {
return;
Expand Down
Loading