MNT Fix unit test (#603)

silverstripe · Sep 30, 2024 · 3939401 · 3939401
1 parent 06d9a71
commit 3939401
Showing 1 changed file with 5 additions and 5 deletions.
diff --git a/tests/php/Service/ThemeResolverTest.php b/tests/php/Service/ThemeResolverTest.php
@@ -11,7 +11,7 @@
 
 class ThemeResolverTest extends SapphireTest
 {
-    protected $themeList = [
+    protected static array $themeList = [
         '$public',
         'custom',
         'main',
@@ -24,15 +24,15 @@ protected function setUp(): void
         parent::setUp();
 
         // Setup known theme config
-        Config::modify()->set(SSViewer::class, 'themes', $this->themeList);
+        Config::modify()->set(SSViewer::class, 'themes', static::$themeList);
     }
 
     public function testSubsiteWithoutThemeReturnsDefaultThemeList()
     {
         $subsite = new Subsite();
         $resolver = new ThemeResolver();
 
-        $this->assertSame($this->themeList, $resolver->getThemeList($subsite));
+        $this->assertSame(static::$themeList, $resolver->getThemeList($subsite));
     }
 
     public function testSubsiteWithCustomThemePrependsToList()
@@ -42,7 +42,7 @@ public function testSubsiteWithCustomThemePrependsToList()
 
         $resolver = new ThemeResolver();
 
-        $expected = array_merge(['subsite'], $this->themeList);
+        $expected = array_merge(['subsite'], static::$themeList);
 
         $this->assertSame($expected, $resolver->getThemeList($subsite));
     }
@@ -135,7 +135,7 @@ public static function customThemeDefinitionsAreRespectedProvider()
                     SSViewer::DEFAULT_THEME,
                 ]],
                 'other',
-                array_merge(['other'], $this->themeList)
+                array_merge(['other'], static::$themeList)
             ],
         ];
     }