API Replace Extension subclasses #593
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emteknetnz
force-pushed
the
pulls/4/replace-extension-subclasses
branch
from
869cb05
to
5ea69d6
Compare
emteknetnz
force-pushed
the
pulls/4/replace-extension-subclasses
branch
from
5ea69d6
to
de55844
Compare
|
CI still failing - I would have said these look unrelated, except the full kitchen sink run was passing so I'd expect this to pass now too. |
emteknetnz
force-pushed
the
pulls/4/replace-extension-subclasses
branch
from
de55844
to
4298c2e
Compare
|
Have fixed up the unit tests Previously there was a fairly point array assertion on extraStatics(), which was a pointless method on DataExtension. I'm not sure why it was passing in sink CI There was also a failure based on the recently merged protected extensions PR, which I've updated to use the equivalent public API instead |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue silverstripe/silverstripe-framework#11050