Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MNT Fix unit test #603

Merged
merged 1 commit into from
Sep 30, 2024
Merged

MNT Fix unit test #603

merged 1 commit into from
Sep 30, 2024

Conversation

GuySartorelli
Copy link
Member

Fixes https://github.com/silverstripe/silverstripe-subsites/actions/runs/11061581662/job/30829569214

  1. SilverStripe\Subsites\Tests\Service\ThemeResolverTest::testCustomThemeDefinitionsAreRespected
    The data provider specified for SilverStripe\Subsites\Tests\Service\ThemeResolverTest::testCustomThemeDefinitionsAreRespected is invalid
    Using $this when not in object context

Issue

@GuySartorelli GuySartorelli mentioned this pull request Sep 30, 2024
Open
@emteknetnz emteknetnz merged commit 3939401 into silverstripe:4 Sep 30, 2024
11 checks passed
@emteknetnz emteknetnz deleted the pulls/4/fix-tests branch September 30, 2024 05:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emteknetnz emteknetnz emteknetnz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GuySartorelli @emteknetnz