Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX Update CMS fields now that they're being scaffolded #1315

Merged
merged 1 commit into from
Aug 15, 2024
Merged

FIX Update CMS fields now that they're being scaffolded #1315

merged 1 commit into from
Aug 15, 2024

Conversation

GuySartorelli
Copy link
Member

@GuySartorelli GuySartorelli commented Aug 8, 2024 •
edited
Loading

@GuySartorelli GuySartorelli mentioned this pull request Aug 8, 2024
Closed
@GuySartorelli GuySartorelli marked this pull request as draft August 8, 2024 01:47
@GuySartorelli GuySartorelli mentioned this pull request Aug 8, 2024
Merged
@GuySartorelli
Copy link
Member Author

PHP linting failure unrelated.
Other CI failures should go green when other PRs are merged (see kitchen sink CI run)

@GuySartorelli GuySartorelli marked this pull request as ready for review August 12, 2024 02:30
emteknetnz
emteknetnz requested changes Aug 15, 2024
View reviewed changes
Copy link
Member

@emteknetnz emteknetnz left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Linting failure :-)

@emteknetnz emteknetnz merged commit 8037b0f into silverstripe:7 Aug 15, 2024
12 of 13 checks passed
@emteknetnz emteknetnz deleted the pulls/7/scaffold-sitetree branch August 15, 2024 02:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emteknetnz emteknetnz emteknetnz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GuySartorelli @emteknetnz