Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API Remove GraphQL #354

Conversation

emteknetnz
Copy link
Member

@emteknetnz emteknetnz commented Jul 26, 2024

@emteknetnz emteknetnz force-pushed the pulls/3/standardise-endpoints branch 10 times, most recently from 1857d0c to bfd1140 Compare July 29, 2024 07:07
@emteknetnz emteknetnz force-pushed the pulls/3/standardise-endpoints branch from bfd1140 to 299fd68 Compare July 30, 2024 06:15
@emteknetnz emteknetnz changed the title API Standardise endpoints API Remove GraphQL Jul 30, 2024
@emteknetnz emteknetnz force-pushed the pulls/3/standardise-endpoints branch 3 times, most recently from 5e522aa to 7f61d8f Compare July 31, 2024 23:31
@emteknetnz emteknetnz force-pushed the pulls/3/standardise-endpoints branch 5 times, most recently from f4f8d3f to 6e2aa71 Compare August 13, 2024 01:35
@emteknetnz emteknetnz marked this pull request as ready for review August 19, 2024 22:14
src/Controllers/HistoryViewerController.php Outdated Show resolved Hide resolved
src/Controllers/HistoryViewerController.php Outdated Show resolved Hide resolved
src/Controllers/HistoryViewerController.php Show resolved Hide resolved
src/Controllers/HistoryViewerController.php Show resolved Hide resolved
src/Controllers/HistoryViewerController.php Outdated Show resolved Hide resolved
@emteknetnz emteknetnz force-pushed the pulls/3/standardise-endpoints branch 4 times, most recently from 5ab8199 to ab91b01 Compare August 22, 2024 07:44
Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, will merge when other PRs are happy

@emteknetnz emteknetnz force-pushed the pulls/3/standardise-endpoints branch from ab91b01 to 80c57b6 Compare August 26, 2024 07:34
@emteknetnz emteknetnz force-pushed the pulls/3/standardise-endpoints branch 4 times, most recently from 149ac5a to 24fcb98 Compare August 28, 2024 00:22
Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, will merge when other PRs are happy

@emteknetnz emteknetnz force-pushed the pulls/3/standardise-endpoints branch from 24fcb98 to f4bad1c Compare August 30, 2024 00:08
Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

re-approved most recent changes

@GuySartorelli GuySartorelli merged commit 45cb904 into silverstripe:3 Sep 2, 2024
5 of 12 checks passed
@GuySartorelli GuySartorelli deleted the pulls/3/standardise-endpoints branch September 2, 2024 04:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants