Merge pull request #354 from GuySartorelli/patch-1

FIX Return correct changed fields when fromRecord is null
silverstripe · Mar 16, 2022 · 3796337 · 3796337
2 parents 7cedcf6 + 28e4080
commit 3796337
Showing 1 changed file with 6 additions and 2 deletions.
diff --git a/src/DataDifferencer.php b/src/DataDifferencer.php
@@ -258,7 +258,11 @@ public function ChangedFields()
      */
     public function changedFieldNames()
     {
-        $diffed = clone $this->fromRecord;
+        if ($this->fromRecord) {
+            $diffed = clone $this->fromRecord;
+        } else {
+            $diffed = clone $this->toRecord;
+        }
         $fields = array_keys($diffed->toMap());
 
         $changedFields = [];
@@ -267,7 +271,7 @@ public function changedFieldNames()
             if (in_array($field, $this->ignoredFields)) {
                 continue;
             }
-            if ($this->fromRecord->$field != $this->toRecord->$field) {
+            if (!$this->fromRecord || $this->fromRecord->$field != $this->toRecord->$field) {
                 $changedFields[] = $field;
             }
         }