MNT Remove TODO comments #418
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sabina-talipova
commented
Oct 10, 2023
| @@ -2656,7 +2655,7 @@ public static function get_latest_version($class, $id) | |||
| /** | |||
| * Returns whether the current record is the latest one. | |||
| * | |||
| * @todo Performance - could do this directly via SQL. | |||
There was a problem hiding this comment.
It looks like an additional way for better performance.
sabina-talipova
commented
Oct 10, 2023
| @@ -201,7 +201,7 @@ public function findOwners($recursive = true, $list = null) | |||
| } | |||
|
|
|||
| // Build reverse lookup for ownership | |||
| // @todo - Cache this more intelligently | |||
There was a problem hiding this comment.
It looks like a small warning.
sabina-talipova
commented
Oct 19, 2023
| @@ -188,8 +188,6 @@ protected function getObjectDisplay($object = null) | |||
| } | |||
|
|
|||
| // Use image tag | |||
| // TODO Use CMSThumbnail instead to limit max size, blocked by DataDifferencerTest and GC | |||
| // not playing nice with mocked images | |||
There was a problem hiding this comment.
Open ticket: #414
sabina-talipova
commented
Oct 19, 2023
| @@ -70,8 +70,7 @@ public function testArrayValues() | |||
| $obj1v2 = Versioned::get_version(DataDifferencerTest\TestObject::class, $obj1->ID, $afterVersion); | |||
| $differ = new DataDifferencer($obj1v1, $obj1v2); | |||
| $obj1Diff = $differ->diffedData(); | |||
| // TODO Using getter would split up field again, bug only caused by simulating | |||
| // an array-based value in the first place. | |||
There was a problem hiding this comment.
Open ticket: #413
sabina-talipova
commented
Oct 19, 2023
| @@ -213,8 +213,6 @@ public function removeObject(DataObject $object) | |||
| ])->first(); | |||
|
|
|||
| if ($item) { | |||
| // TODO: Handle case of implicit added item being removed. | |||
There was a problem hiding this comment.
Open ticket: #415
sabina-talipova
commented
Oct 19, 2023
sabina-talipova
commented
Oct 19, 2023
| @@ -2021,7 +2021,6 @@ public function Versions($filter = "", $sort = "", $limit = "", $join = "", $hav | |||
|
|
|||
| $list = DataObject::get(DataObject::getSchema()->baseDataClass($owner), $filter, $sort, $join, $limit); | |||
| if ($having) { | |||
| // @todo - This method doesn't exist on DataList | |||
There was a problem hiding this comment.
Open ticket: #417
GuySartorelli
requested changes
Oct 19, 2023
sabina-talipova
force-pushed
the
pulls/2.1/remove-todo
branch
from
7b0e144
to
2d0bd7b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Parent issue