Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MNT Remove TODO comments #418

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions src/ChangeSet.php
Original file line number Diff line number Diff line change
Expand Up @@ -213,8 +213,6 @@ public function removeObject(DataObject $object)
])->first();

if ($item) {
// TODO: Handle case of implicit added item being removed.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Open ticket: #415


$item->delete();
}

Expand Down
2 changes: 0 additions & 2 deletions src/DataDifferencer.php
Original file line number Diff line number Diff line change
Expand Up @@ -188,8 +188,6 @@ protected function getObjectDisplay($object = null)
}

// Use image tag
// TODO Use CMSThumbnail instead to limit max size, blocked by DataDifferencerTest and GC
// not playing nice with mocked images
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Open ticket: #414

if ($object instanceof Image) {
return $object->getTag();
}
Expand Down
1 change: 0 additions & 1 deletion src/RecursivePublishable.php
Original file line number Diff line number Diff line change
Expand Up @@ -201,7 +201,6 @@ public function findOwners($recursive = true, $list = null)
}

// Build reverse lookup for ownership
// @todo - Cache this more intelligently
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like a small warning.

$rules = $this->lookupReverseOwners();

// Hand off to recursive method
Expand Down
1 change: 0 additions & 1 deletion src/RecursivePublishableHandler.php
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@ class RecursivePublishableHandler extends Extension
{
/**
* Ensure that non-versioned records are published on save.
* @todo Build this action into explicit UX action: https://github.com/silverstripe/silverstripe-versioned/issues/71
GuySartorelli marked this conversation as resolved.
Show resolved Hide resolved
* @param DataObject $record
*/
public function onAfterSave(DataObject $record)
Expand Down
3 changes: 0 additions & 3 deletions src/Versioned.php
Original file line number Diff line number Diff line change
Expand Up @@ -2021,7 +2021,6 @@ public function Versions($filter = "", $sort = "", $limit = "", $join = "", $hav

$list = DataObject::get(DataObject::getSchema()->baseDataClass($owner), $filter, $sort, $join, $limit);
if ($having) {
// @todo - This method doesn't exist on DataList
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Open ticket: #417

$list->having($having);
}

Expand Down Expand Up @@ -2656,8 +2655,6 @@ public static function get_latest_version($class, $id)
/**
* Returns whether the current record is the latest one.
*
* @todo Performance - could do this directly via SQL.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like an additional way for better performance.

*
* @see get_latest_version()
* @see latestPublished
*
Expand Down
3 changes: 1 addition & 2 deletions tests/php/DataDifferencerTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -70,8 +70,7 @@ public function testArrayValues()
$obj1v2 = Versioned::get_version(DataDifferencerTest\TestObject::class, $obj1->ID, $afterVersion);
$differ = new DataDifferencer($obj1v1, $obj1v2);
$obj1Diff = $differ->diffedData();
// TODO Using getter would split up field again, bug only caused by simulating
// an array-based value in the first place.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Open ticket: #413


$this->assertContainsIgnoreWhitespace('<del>a,b</del><ins>a</ins>', $obj1Diff->getField('Choices'));
}

Expand Down