feat: add settings param to insert calls (#173)

simPod · Oct 9, 2022 · 87a91eb · 87a91eb
1 parent d7d6771
commit 87a91eb
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 6 deletions.
diff --git a/src/Client/ClickHouseClient.php b/src/Client/ClickHouseClient.php
@@ -42,13 +42,15 @@ public function selectWithParams(string $query, array $params, Format $outputFor
     /**
      * @param array<array<mixed>> $values
      * @param array<string>|null $columns
+     * @param array<string, float|int|string> $settings
      */
-    public function insert(string $table, array $values, array|null $columns = null): void;
+    public function insert(string $table, array $values, array|null $columns = null, array $settings = []): void;
 
     /**
+     * @param array<string, float|int|string> $settings
      * @param Format<O> $inputFormat
      *
      * @template O of Output
      */
-    public function insertWithFormat(string $table, Format $inputFormat, string $data): void;
+    public function insertWithFormat(string $table, Format $inputFormat, string $data, array $settings = []): void;
 }
diff --git a/src/Client/PsrClickHouseClient.php b/src/Client/PsrClickHouseClient.php
@@ -90,7 +90,7 @@ public function selectWithParams(string $query, array $params, Format $outputFor
     /**
      * {@inheritDoc}
      */
-    public function insert(string $table, array $values, array|null $columns = null): void
+    public function insert(string $table, array $values, array|null $columns = null, array $settings = []): void
     {
         if ($values === []) {
             throw CannotInsert::noValues();
@@ -124,11 +124,12 @@ public function insert(string $table, array $values, array|null $columns = null)
 INSERT INTO $table
 $columnsSql
 VALUES $valuesSql
-CLICKHOUSE
+CLICKHOUSE,
+            $settings
         );
     }
 
-    public function insertWithFormat(string $table, Format $inputFormat, string $data): void
+    public function insertWithFormat(string $table, Format $inputFormat, string $data, array $settings = []): void
     {
         $formatSql = $inputFormat::toSql();
 
@@ -137,7 +138,8 @@ public function insertWithFormat(string $table, Format $inputFormat, string $dat
         $this->executeRequest(
             <<<CLICKHOUSE
 INSERT INTO $table $formatSql $data
-CLICKHOUSE
+CLICKHOUSE,
+            $settings
         );
     }