refactor(async-client): rename sql param to query (#233)

simPod · Jan 12, 2024 · c8e8cdd · c8e8cdd
1 parent ffd60ff
commit c8e8cdd
Show file tree

Hide file tree

Showing 3 changed files with 17 additions and 17 deletions.
diff --git a/src/Client/ClickHouseAsyncClient.php b/src/Client/ClickHouseAsyncClient.php
@@ -17,7 +17,7 @@ interface ClickHouseAsyncClient
      *
      * @template O of Output
      */
-    public function select(string $sql, Format $outputFormat, array $settings = []): PromiseInterface;
+    public function select(string $query, Format $outputFormat, array $settings = []): PromiseInterface;
 
     /**
      * @param array<string, mixed>            $params
@@ -27,7 +27,7 @@ public function select(string $sql, Format $outputFormat, array $settings = []):
      * @template O of Output
      */
     public function selectWithParams(
-        string $sql,
+        string $query,
         array $params,
         Format $outputFormat,
         array $settings = [],

diff --git a/src/Client/PsrClickHouseAsyncClient.php b/src/Client/PsrClickHouseAsyncClient.php
@@ -37,15 +37,15 @@ public function __construct(
      *
      * @throws Exception
      */
-    public function select(string $sql, Format $outputFormat, array $settings = []): PromiseInterface
+    public function select(string $query, Format $outputFormat, array $settings = []): PromiseInterface
     {
         $formatClause = $outputFormat::toSql();
 
         return $this->executeRequest(
             <<<CLICKHOUSE
-$sql
-$formatClause
-CLICKHOUSE,
+            $query
+            $formatClause
+            CLICKHOUSE,
             $settings,
             static fn (ResponseInterface $response): Output => $outputFormat::output($response->getBody()->__toString())
         );
@@ -57,13 +57,13 @@ public function select(string $sql, Format $outputFormat, array $settings = []):
      * @throws Exception
      */
     public function selectWithParams(
-        string $sql,
+        string $query,
         array $params,
         Format $outputFormat,
         array $settings = [],
     ): PromiseInterface {
         return $this->select(
-            $this->sqlFactory->createWithParameters($sql, $params),
+            $this->sqlFactory->createWithParameters($query, $params),
             $outputFormat,
             $settings,
         );

diff --git a/src/Client/PsrClickHouseClient.php b/src/Client/PsrClickHouseClient.php
@@ -58,9 +58,9 @@ public function select(string $query, Format $outputFormat, array $settings = []
 
         $response = $this->executeRequest(
             <<<CLICKHOUSE
-$query
-$formatClause
-CLICKHOUSE,
+            $query
+            $formatClause
+            CLICKHOUSE,
             $settings,
         );
 
@@ -107,10 +107,10 @@ public function insert(string $table, array $values, array|null $columns = null,
 
         $this->executeRequest(
             <<<CLICKHOUSE
-INSERT INTO $table
-$columnsSql
-VALUES $valuesSql
-CLICKHOUSE,
+            INSERT INTO $table
+            $columnsSql
+            VALUES $valuesSql
+            CLICKHOUSE,
             $settings,
         );
     }
@@ -123,8 +123,8 @@ public function insertWithFormat(string $table, Format $inputFormat, string $dat
 
         $this->executeRequest(
             <<<CLICKHOUSE
-INSERT INTO $table $formatSql $data
-CLICKHOUSE,
+            INSERT INTO $table $formatSql $data
+            CLICKHOUSE,
             $settings,
         );
     }