test: run on y24 lts

simPod · Jan 15, 2025 · d5236a5 · d5236a5
1 parent b680a8d
commit d5236a5
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 12 deletions.
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -73,6 +73,8 @@ jobs:
           - "23.7"
           - "23.8"
           - "23.9"
+          - "24.3"
+          - "24.8"
         dependency-versions:
           - "highest"
     env:

diff --git a/tests/Param/ParamValueConverterRegistryTest.php b/tests/Param/ParamValueConverterRegistryTest.php
@@ -30,6 +30,7 @@ final class ParamValueConverterRegistryTest extends TestCaseBase
 {
     use WithClient;
 
+    private const VersionLineString   = 2309;
     private const VersionIntervalJson = 2301;
 
     /** @var array<string> */
@@ -239,19 +240,22 @@ public static function providerConvert(): Generator
         yield 'Point (array)' => ['Point', [1, 2], '(1,2)'];
         yield 'Ring' => ['Ring', '[(1,2),(3,4)]', '[(1,2),(3,4)]'];
         yield 'Ring (array)' => ['Ring', [[1, 2], [3, 4]], '[(1,2),(3,4)]'];
-        yield 'LineString' => ['LineString', '[(1,2),(3,4)]', '[(1,2),(3,4)]'];
-        yield 'LineString (array)' => ['LineString', [[1, 2], [3, 4]], '[(1,2),(3,4)]'];
-        yield 'MultiLineString' => [
-            'MultiLineString',
-            '[[(1,2),(3,4)],[(5,6),(7,8)]]',
-            '[[(1,2),(3,4)],[(5,6),(7,8)]]',
-        ];
 
-        yield 'MultiLineString (array)' => [
-            'MultiLineString',
-            [[[1, 2], [3, 4]], [[5, 6], [7, 8]]],
-            '[[(1,2),(3,4)],[(5,6),(7,8)]]',
-        ];
+        if (ClickHouseVersion::get() >= self::VersionLineString) {
+            yield 'LineString' => ['LineString', '[(1,2),(3,4)]', '[(1,2),(3,4)]'];
+            yield 'LineString (array)' => ['LineString', [[1, 2], [3, 4]], '[(1,2),(3,4)]'];
+            yield 'MultiLineString' => [
+                'MultiLineString',
+                '[[(1,2),(3,4)],[(5,6),(7,8)]]',
+                '[[(1,2),(3,4)],[(5,6),(7,8)]]',
+            ];
+
+            yield 'MultiLineString (array)' => [
+                'MultiLineString',
+                [[[1, 2], [3, 4]], [[5, 6], [7, 8]]],
+                '[[(1,2),(3,4)],[(5,6),(7,8)]]',
+            ];
+        }
 
         yield 'Polygon' => ['Polygon', '[[(1,2),(3,4)],[(5,6),(7,8)]]', '[[(1,2),(3,4)],[(5,6),(7,8)]]'];
         yield 'Polygon (array)' => ['Polygon', [[[1, 2], [3, 4]], [[5, 6], [7, 8]]], '[[(1,2),(3,4)],[(5,6),(7,8)]]'];
-Original file line number
+Diff line change
@@ Expand Up / @@ -73,6 +73,8 @@ jobs: @@
               - "23.7"
               - "23.8"
               - "23.9"
+              - "24.3"
+              - "24.8"
             dependency-versions:
               - "highest"
         env:
@@ Expand Down @@