Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: pass parameters natively via http interface along the query #224

Merged
merged 1 commit into from
Jan 17, 2024

Conversation

simPod
Copy link
Owner

@simPod simPod commented Jan 12, 2024

  • Rename UnsupportedValue exception to UnsupportedParamValue
  • This deprecates using :param in queries. Migrate to native query params.

@simPod simPod force-pushed the parameters branch 2 times, most recently from 68bb17d to 8252715 Compare January 12, 2024 09:14
Copy link

codecov bot commented Jan 12, 2024

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (2cbdc98) 91.66% compared to head (b072107) 93.21%.

Files Patch % Lines
src/Client/PsrClickHouseClient.php 82.14% 5 Missing ⚠️
src/Client/Http/RequestFactory.php 94.11% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #224      +/-   ##
==========================================
+ Coverage   91.66%   93.21%   +1.54%     
==========================================
  Files          35       38       +3     
  Lines         420      604     +184     
==========================================
+ Hits          385      563     +178     
- Misses         35       41       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@simPod simPod force-pushed the parameters branch 27 times, most recently from 20d53a5 to c8b8036 Compare January 16, 2024 18:56
@simPod simPod force-pushed the parameters branch 22 times, most recently from 63a176d to cbe71ab Compare January 17, 2024 13:27
@simPod simPod marked this pull request as ready for review January 17, 2024 13:31
@simPod simPod merged commit 3f2c466 into master Jan 17, 2024
32 checks passed
@simPod simPod deleted the parameters branch January 17, 2024 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant