Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

please port to SDL2 #3

Open
a-detiste opened this issue Apr 1, 2024 · 7 comments
Open

please port to SDL2 #3

a-detiste opened this issue Apr 1, 2024 · 7 comments

Comments

@a-detiste
Copy link
Contributor

SDL1 is slowly being removed

In fact it has already replace by sdl1-compat which is a stub library that wraps SDL2;
but not ... perfectly

SDL2 has better Wayland support

https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1038484

@simenheg
Copy link
Owner

simenheg commented Apr 3, 2024

It would be nice to have an SDL2 port, I even attempted one a couple of years ago: master...sdl2. I think it still has a long way to go.

I'm not sure I'll have the time or motivation to go through with the port, but if anyone wants to have a go at it, help would be greatly appreciated!

@stianval
Copy link

I've been playing with this for a while, and think I have something working now. I think I can clean up a bit and make a PR within the next few days.

@simenheg
Copy link
Owner

Very cool, @stianval! I'll check out the PR as soon as I get the chance. 😃

@simenheg
Copy link
Owner

I've merged #4. The game seems to work pretty well now in my testing, thanks a lot @stianval!

A few remaining bugs I've noticed during testing:

  • There are some problems switching between fullscreen and windowed mode.
  • The Ghost walk weapon turns the screen black.

stianval added a commit to stianval/zatackax that referenced this issue Nov 19, 2024
Addresses the two remaining issues from issue simenheg#3
stianval added a commit to stianval/zatackax that referenced this issue Nov 23, 2024
Addresses the two remaining issues from issue simenheg#3
@simenheg
Copy link
Owner

simenheg commented Dec 3, 2024

I've discovered another regression from the SDL1 version, though I don't know how easy/possible it is to support it in SDL2. In the SDL1 version, you could resize the window to some shape you'd like for the map (or even maximize the window), and the map would reshape accordingly, whereas in the SDL2 version, the graphics are scaled/stretched instead.

@a-detiste
Copy link
Contributor Author

Take your time and enjoy the ride ;-)

@stianval
Copy link

stianval commented Dec 7, 2024

I've discovered another regression from the SDL1 version, though I don't know how easy/possible it is to support it in SDL2. In the SDL1 version, you could resize the window to some shape you'd like for the map (or even maximize the window), and the map would reshape accordingly, whereas in the SDL2 version, the graphics are scaled/stretched instead.

I just tested the SDL1 version and I think the behavior should not be too difficult to recreate. The main difficulty would be to keep the window size for fullscreen mode, but I think that should also be doable ;)

stianval added a commit to stianval/zatackax that referenced this issue Dec 11, 2024
Another feature for parity with SDL1 version

Issue simenheg#3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants