remove leading slashes from URI paths #2565
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 14, 2023 18:21
simolus3
reviewed
Aug 15, 2023
| final fs = await IndexedDbFileSystem.open(dbName: dbName); | ||
| sqlite3.registerVirtualFileSystem(fs, makeDefault: true); | ||
|
|
||
| final wasmDb = WasmDatabase(sqlite3: sqlite3, path: '/app.db'); | ||
| final wasmDb = WasmDatabase(sqlite3: sqlite3, path: 'app.db'); |
There was a problem hiding this comment.
I actually prefer that the path here and the one for xOpen stay absolute. These refer to the path within the virtual file system implementation and aren't resolved to anything by the browser.
(The default working directory we assume is / so both work, but this change is unrelated to the issue of not being able to load the worker and it's safer to use absolute paths)
Comment on lines
+6
to
+7
| content on <http://localhost:8080>. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to allow for drift web setups where the app is served from a subdirectory, the leading slashes have been removed from the Uri.parse() calls.