Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Picture placements #24

Merged
merged 4 commits into from
Jan 16, 2024
Merged

Picture placements #24

merged 4 commits into from
Jan 16, 2024

Commits on Jan 16, 2024

  1. Create Picture and PicturePlacement

    @simonhamp
    simonhamp committed Jan 16, 2024
    Configuration menu
    Copy the full SHA
    ea05bb8 View commit details
    Browse the repository at this point in the history

  2. Change to using Picture objects

    @simonhamp
    simonhamp committed Jan 16, 2024
    Configuration menu
    Copy the full SHA
    f84a5a0 View commit details
    Browse the repository at this point in the history

  3. Support different placements

    @simonhamp
    simonhamp committed Jan 16, 2024
    Configuration menu
    Copy the full SHA
    148be09 View commit details
    Browse the repository at this point in the history

  4. Fix for non-square images 

    The positioning was based on the defined size of the box rather than the actual dimensions of the image

This resolves that by 'pre-rendering' the image and getting its final dimensions before positioning the box
    @simonhamp
    simonhamp committed Jan 16, 2024
    Configuration menu
    Copy the full SHA
    bc6409d View commit details
    Browse the repository at this point in the history