Improvements to per-side notes and mint marks #145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fetching the per-side fields from the arrays when deciding the filename isn't correct, and the arrays were too short.
atsampson
added
bug
Domesday Duplicator GUI
This is needed in C because () means any arguments are permitted, but in C++ () always means no arguments.
Make the style of the text labels match the rest of the UI (i.e. don't capitalise every word), and don't use radio buttons when there are only two options to choose from.
It's a bit awkward having this in two places anyway; it'd be nicer if it could just load it from a default Configuration.
These are individually configurable because it's reasonable to want one but not the other (e.g. if you're using the notes field to record the player used).
This is harmless, but Qt 6 warns about it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CC @Gamnn, who'd also spotted this.
Rework the per-side notes and mint mark logic, since it wasn't producing sensible filenames in some cases.
Add UI settings to enable each of these to be enabled/disabled individually, since not everybody will want this behaviour at all, and it can be useful to enable only one (e.g. if you use notes to log the player used).
As this adds new settings to the UI tab, simplify the amplitude display settings and make them match the style of the rest of the UI.
Remove C-style
(void)arguments throughout the DDD code.