Fixed Atom data corruption during writes

The 16-bit data writes from Atom devices was losing the upper 8-bits, causing every other byte written to disk to be zero. This didn't affect Atom Lite devices as they drive the Compact Flash device in 8-bit mode.
simonowen · Jul 11, 2020 · ad1c145 · ad1c145
1 parent e0e8a79
commit ad1c145
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 2 deletions.
diff --git a/Base/AtaAdapter.cpp b/Base/AtaAdapter.cpp
@@ -46,13 +46,18 @@ WORD CAtaAdapter::InWord(WORD wPort_)
     return wRet;
 }
 
-// 8-bit write (16-bit handled by derived class)
 void CAtaAdapter::Out(WORD wPort_, BYTE bVal_)
 {
     if (m_pDisk0) m_pDisk0->Out(wPort_, bVal_);
     if (m_pDisk1) m_pDisk1->Out(wPort_, bVal_);
 }
 
+void CAtaAdapter::OutWord(WORD wPort_, WORD wVal_)
+{
+    if (m_pDisk0) m_pDisk0->Out(wPort_, wVal_);
+    if (m_pDisk1) m_pDisk1->Out(wPort_, wVal_);
+}
+
 
 void CAtaAdapter::Reset()
 {

diff --git a/Base/AtaAdapter.h b/Base/AtaAdapter.h
@@ -47,6 +47,7 @@ class CAtaAdapter : public CIoDevice
 
 protected:
     WORD InWord(WORD wPort_);
+    void OutWord(WORD wPort_, WORD wVal_);
 
 protected:
     UINT m_uActive = 0; // active when non-zero, decremented by FrameEnd()

diff --git a/Base/Atom.cpp b/Base/Atom.cpp
@@ -86,7 +86,7 @@ void CAtomDevice::Out(WORD wPort_, BYTE bVal_)
             break;
 
         m_uActive = HDD_ACTIVE_FRAMES;
-        CAtaAdapter::Out(m_bAddressLatch & ATOM_ADDR_MASK, (m_bWriteLatch << 8) | bVal_);
+        CAtaAdapter::OutWord(m_bAddressLatch & ATOM_ADDR_MASK, (m_bWriteLatch << 8) | bVal_);
         break;
 
     default: