Make isMultiple non-greedy
#162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I.e don't consume more than one argument
|
I think we should explicitly document this behavior. |
|
Bump :) |
|
Yeah, sorry. I started looking into it, but then my son woke up 😅 I'll get to it in the coming days. |
Prettier setting to adhere to current formatting, anyone?
|
@sindresorhus Alright. All yours. |
|
LGTM 👍 |
|
Came to think of: do we want the tests to be as explicit? We have a test for space-separation. Should I add a test for a comma-separated value as well? I mean, to "document" the (non-)behavior. |
|
Went ahead and added it. Feel free to skip/revert. |
|
Thanks for this 👍🏻 |
voxpelli
added a commit
to voxpelli/node-installed-check
that referenced
this pull request
Jan 28, 2021
Includes fix for sindresorhus/meow#162
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I.e don't consume more than one argument.
The default behavior of
yargs-parseris to greedily consume array flag arguments.I also realized it doesn't support comma-separated values. Not sure if we want that or not, but I'll make a separate PR and let you be the judge.
Fixes #160