SyntaxError: Invalid regular expression: invalid group specifier name #105

muuvmuuv · 2020-02-03T21:55:01Z

Hey, I'm getting this error here on iOS and macOS Safari:

SyntaxError: Invalid regular expression: invalid group specifier name

It comes from here:

// Remove duplicate slashes if not preceded by a protocol
if (urlObj.pathname) {
  urlObj.pathname = urlObj.pathname.replace(/(?<!https?:)\/{2,}/g, '/');
}

My code: https://github.com/muuvmuuv/portfolio/blob/master/src/elements/Link.jsx
Live error: https://portfolio-git-development.muuvmuuv.now.sh/

I am using version 5.x

The text was updated successfully, but these errors were encountered:

TrySound · 2020-02-03T22:05:51Z

@muuvmuuv Look here for details
76172da#diff-168726dbe96b3ce427e7fedce31bb0bcR120

muuvmuuv · 2020-02-03T22:14:44Z

Oh... what a shame. Thought it says >4 not =4 but okay will fix the version tho.

Can we leave this open until browsers will add support for negative lookbehinds?

Browser support:

kornysietsma · 2020-03-26T11:09:44Z

Note that this also impacts Gatsby projects in "develop" mode on firefox 74 (current) - negative lookbehinds work for building a site, but when developing it also rebuilds pages in the browser.

The latest version doesn't work on Safari and Firefox. See here: sindresorhus/normalize-url#105

exentrich · 2020-06-05T06:54:59Z

It's critical issue! Page that uses normalize-url version 5 can't be opened in iOS nor macOS!

TrySound · 2020-06-05T08:01:13Z

See here https://github.com/sindresorhus/normalize-url#install

muuvmuuv · 2020-06-06T14:37:23Z

It is getting some support from browsers now. Maybe some more month and v5 will be working in all major browsers as well. I'm using it in a Ionic app. Need to try if v5 works for it.

muuvmuuv · 2020-08-19T09:12:25Z

Alternative would be to use this package. Just as long as browsers are not fully support it.

Sandbox: https://codesandbox.io/s/normalize-url-issues-105-sex88?file=/src/index.js

Aarbel · 2021-03-14T23:49:06Z

I confirm that installing v4 package solves the problem on WkWebview (iOS)

npm i normalize-url@4

whalemare · 2021-05-12T07:54:15Z

Not worked version 6 and version 4 on iOS react-native.

Crashed with error: TypeError: Attempted to assign to readonly property.

import normalizeUrl from 'normalize-url'
const normalized = normalizeUrl('fb.com')

fcisio · 2021-05-20T17:26:05Z

Hey, I'm coming from Gatsby, thanks a lot for this issue.
As mentioned above, it's a critical issue.

And this has been open for a while. Any Idea why there hasn't been any progress on something that seems like a simple syntax error?

Thanks

gregdingle · 2021-06-03T19:15:17Z

I also got burned by this issue. I don't see how it's good to release new versions that are known to be broken in Safari. There must be another regex that doesn't use negative lookbehinds. @gcox ?

gcox · 2021-06-03T19:44:25Z

@gregdingle Not sure if you meant to reference me, but I don't see how to avoid the negative lookbehinds. I'm certainly no regex expert so I can't say it's impossible. I don't use this in a browser either, so I'm not motivated to try to work around an annoying browser limitation.

edenhermelin · 2021-07-28T21:11:53Z

any updates on that? or it is not planned to implement a workaround for the regex?

muuvmuuv · 2021-07-29T07:19:25Z

Still no native support for Safari... @edenhermelin I mentioned a workaround in an earlier comment but it seems it wont be implemented.

loynoir · 2021-08-07T23:00:57Z

Hi, @muuvmuuv
Can you please help me test #146

I don't have available environment.

muuvmuuv · 2021-08-08T11:30:20Z

@loynoir I have not touched my portfolio a long time, I will try to. No promise.

loynoir · 2021-08-08T14:27:21Z

@muuvmuuv
Sorry to bother you. The real browser test in blocking by another issue.

I tried to port test.js to use mocha+chai, to let you easy test with index.html.

But unfortunatly seems at least two bugs, make browser-normalize-url stuck in v4 and cant up to v7.

this one, (should be fixed?)
and Error result when url using custom protocol in browser #147

loynoir · 2021-08-08T14:38:29Z

Did any one test v4 in real browser? So I don't have to test again myself.

1. [test] Move `ava` to `mocha+chai` to test in real browser. (sindresorhus#105) (sindresorhus#140) (sindresorhus#142) 2. [test] seprate non special-protocol-schemes(sindresorhus#147) 3. [doc] Update readme

loynoir · 2021-08-09T00:44:34Z

I think, this error raise from normalize-url@v7.0.0 should be fixed in pull/146.

If anyone see this, with browser not support js-regexp-lookbehind,
you can use your real browser to test browser-test/index.html within
https://github.com/loynoir/normalize-url

You can also build that bundle using npm run build

loynoir · 2021-08-09T01:26:30Z

@muuvmuuv and any who volunteer to test browser version of normalize-url@7

I publish tests in git repo, so you can visit thru rawgit

https://ghcdn.rawgit.org/loynoir/normalize-url/main/browser-test/index.html

PS: just ignore title with non-special-protocol-schemes which belongs to another issue

tuarrep · 2021-08-09T06:24:22Z

Just tested on my iPhone under iOS 15 beta. Two tests are failing see below.

If I remember well I’ve encountered this issue on my MacBook with Safari, I’ll test on it too later this day

JKrol · 2021-08-09T06:51:22Z

@loynoir here is the result from iPad, Safari:

muuvmuuv · 2021-08-09T07:02:51Z

Got the same as above from Windows 10 Microsoft Edge latest release

loynoir · 2021-08-09T07:38:04Z

Invalid URL

This is because of the test regexp is hard-coded, I push a commit allow less strict checking.

~~But seems rawgit cache haven't refresh.~~

https://ghcdn.rawgit.org/loynoir/normalize-url/f9f36c8f22b9649f0eac7219c31a9da2beef7896/browser-test/index.html

duplicate slashes
I pick logic from v4.5.0 as fallback, it's unexpected.
Did any one know which minor version of v4 works best?
special-protocol-schemes
Kind of weird that 3/3 of you failed on same 2 errors, but I failed in a totally different 4 caused by custom protocol 'sindre://www.sorhus.com' 😂
Under "Mozilla Firefox 90" & "Google Chrome 92"

JKrol · 2021-08-09T09:48:28Z

@loynoir, so after this commit (https://ghcdn.rawgit.org/loynoir/normalize-url/f9f36c8f22b9649f0eac7219c31a9da2beef7896/browser-test/index.html), you expect to fix the invalid url test fail? It did not work for me - I still get the same two failed tests on iPad (checked on Safari and Chrome).

I have also checked the Windows Chrome and Android Chrome now, and I have a different result than on iPad - it is the same as yours.

EDIT: actually there is a small change with Invlaid URL test - previously it failed with expected [Function] and now it is expected 'Type error'

loynoir · 2021-08-09T10:38:04Z

Folded as outdated

duplicate slashes

duplicate slashes
I pick logic from v4.5.0 as fallback, it's unexpected.
Did any one know which minor version of v4 works best?

I can reproduce that after I run into that fallback v4 logic.
If anyone interest,

v4.js pass v4 test.js
v7 test.js add many tests
v4 fallback logic still pass the old v4 test.js
v4 fallback logic not pass v7 test.js ADDED test
default logic pass both v4 test.js and v7 test.js

I just so trust the v4 code, I didn't comment out the default logic to reproduce. Sorry for waste your time.
@tuarrep @JKrol @muuvmuuv

For sake of testing, I think preferJsRegexpLookbehind: false or something, has to be added.

But, as v4 fallback logic not pass v7 test.js ADDED test, I write new logic using reverse + look ahead + reverse as new fallback.

2 logic: look-behind and look-ahead
2 period test: v4 & v7
2 browser: latest chrome and latest firefox
8 situations remove duplicate slashes pass test on my side.

https://ghcdn.rawgit.org/loynoir/normalize-url/8bace639547eae21df941c57a9cec1ed0ce994a6/browser-test/index.html

loynoir · 2021-08-09T11:04:37Z

@JKrol
Sorry, I can't reproduce on firefox90 and chrome92.
Maybe you can try to find what happen.
And, that test is expected to throw an error, but seems somehow it's not try-catched.
Is it fail in invalid url loose test or invalid url strict test?
If it failed in invalid url strict, that is somehow expected, because it use a regexp to detect whether the error is url error constructing.

loynoir · 2021-08-10T14:13:11Z

New Browser Test Link

https://ghcdn.rawgit.org/loynoir/normalize-url/0fd8bf27b3400d4cf67bce6072c3f34efa8f4e56/browser-test/index.html

Test Status

(32/32) Test passed with

Node.js 14
Chrome headless driver
Firefox headless driver
Chrome 92
Firefox 90
Firefox 68 ESR
Opera59
Yandex 7 (2017)

gcox · 2021-08-10T15:58:35Z

@loynoir FYI, 1 test fails in Safari 14.1.2 (16611.3.10.1.3) on macOS 11.5

sindresorhus · 2021-08-11T13:37:47Z

Fixed in https://github.com/sindresorhus/normalize-url/releases/tag/v7.0.1

loynoir · 2021-08-11T17:56:21Z

Hi, @gcox
Can you run this in safari,

// sindresorhus/normalize-url v7.0.1
normalizeUrl('http://');

Does its error.message match /^Invalid URL/?

normalize-url/test.js

Line 272 in 2456033

message: /^Invalid URL/,

As, TypeError seems too wide to match.

loynoir · 2021-08-11T19:12:10Z

New Browser Test Link

https://ghcdn.rawgit.org/loynoir/normalize-url/9c1db991194b0f4f69f9fd03770c77999eb5da68/browser-test/index.html

Test Status

(31/31) Test passed with

Node.js 14
Chrome headless driver
Firefox headless driver
Chrome 92
Firefox 90
Firefox 68 ESR
Opera59
Yandex 7 (2017)

gcox · 2021-08-11T19:21:43Z

Can you run this in safari,
// sindresorhus/normalize-url v7.0.1
normalizeUrl('http://');
Does its error.message match /^Invalid URL/?

Tried it at a break point when loading the new test page and yes, that's the error it produces.

loynoir · 2021-08-11T19:24:16Z

@gcox Can you please test this? I tried to bring it back to old browser.

I tested on a 2017 browser which seems ok, but i lack of a safari env.

https://ghcdn.rawgit.org/loynoir/normalize-url/9c1db991194b0f4f69f9fd03770c77999eb5da68/browser-test/index.html

gcox · 2021-08-11T19:24:45Z

@loynoir All the tests pass

loynoir · 2021-08-11T19:26:40Z

Thanks very much! 😘

muuvmuuv mentioned this issue Feb 3, 2020

[normalize-url] SyntaxError: Invalid regular expression muuvmuuv/portfolio#8

Closed

eysi09 added a commit to garden-io/garden that referenced this issue Apr 3, 2020

fix(dashboard): fix normalize-url to version 4

1edfd27

The latest version doesn't work on Safari and Firefox. See here: sindresorhus/normalize-url#105

This was referenced Apr 3, 2020

Test dashboard in CI garden-io/garden#1768

Closed

fix(dashboard): fix normalize-url to version 4 garden-io/garden#1769

Merged

eysi09 added a commit to garden-io/garden that referenced this issue Apr 3, 2020

fix(dashboard): fix normalize-url to version 4

5c3b082

The latest version doesn't work on Safari and Firefox. See here: sindresorhus/normalize-url#105

eysi09 added a commit to garden-io/garden that referenced this issue Apr 3, 2020

fix(dashboard): fix normalize-url to version 4

cf4b85a

The latest version doesn't work on Safari and Firefox. See here: sindresorhus/normalize-url#105

eysi09 added a commit to garden-io/garden that referenced this issue Apr 3, 2020

fix(dashboard): fix normalize-url to version 4

7f34a57

The latest version doesn't work on Safari and Firefox. See here: sindresorhus/normalize-url#105

iambrianfung mentioned this issue Apr 8, 2021

ads.brave.com does not load on iOS (blank page) brave/ads-ui#564

Closed

JKrol mentioned this issue Jun 2, 2021

iOS plugin not loading disclave/disclave#189

Closed

moT01 mentioned this issue Jun 14, 2021

fix(client): downgrade normalize-url to fix Safari issue freeCodeCamp/freeCodeCamp#42490

Merged

4 tasks

ahus1 mentioned this issue Jun 22, 2021

Document don't load in Safari ahus1/anita-editor#67

Closed

egnwd mentioned this issue Jul 9, 2021

Backstage doesn't load in Safari (when using @backstage/integration-react) backstage/backstage#6426

Closed

alexmt mentioned this issue Jul 12, 2021

fix(ui): Safari crashed after upgrading react-diff-viewer argoproj/argo-cd#6702

Closed

10 tasks

rbreeze mentioned this issue Jul 12, 2021

Diff View component causes crash in Safari otakustay/react-diff-view#129

Closed

alexmt mentioned this issue Jul 12, 2021

fix: downgrade normalize-url to avoid crash in safari argoproj/argo-cd#6703

Merged

sindresorhus mentioned this issue Jul 14, 2021

Can I use version 7 in the browser? #140

Closed

loynoir added a commit to loynoir/normalize-url that referenced this issue Aug 7, 2021

Add useJsRegexpLookbehind option (sindresorhus#105)

6dd9ad1

loynoir added a commit to loynoir/normalize-url that referenced this issue Aug 7, 2021

Add preferJsRegexpLookbehind option (sindresorhus#105)

1228663

loynoir mentioned this issue Aug 7, 2021

Enable real browser test #146

Closed

sindresorhus closed this as completed Aug 11, 2021

muuvmuuv mentioned this issue Nov 25, 2021

SyntaxError: Invalid regular expression: invalid group specifier name gatsbyjs/gatsby#21173

Closed

blake-kc mentioned this issue Feb 25, 2022

Unable to run on Safari due to normalize-url bug ccpu/storybook-addon-playwright#34

Open

SyntaxError: Invalid regular expression: invalid group specifier name #105

SyntaxError: Invalid regular expression: invalid group specifier name #105

Comments

muuvmuuv commented Feb 3, 2020

TrySound commented Feb 3, 2020

muuvmuuv commented Feb 3, 2020

kornysietsma commented Mar 26, 2020

exentrich commented Jun 5, 2020

TrySound commented Jun 5, 2020

muuvmuuv commented Jun 6, 2020

muuvmuuv commented Aug 19, 2020

Aarbel commented Mar 14, 2021 • edited Loading

whalemare commented May 12, 2021

fcisio commented May 20, 2021

gregdingle commented Jun 3, 2021

gcox commented Jun 3, 2021

edenhermelin commented Jul 28, 2021

muuvmuuv commented Jul 29, 2021

loynoir commented Aug 7, 2021

muuvmuuv commented Aug 8, 2021

loynoir commented Aug 8, 2021

loynoir commented Aug 8, 2021

loynoir commented Aug 9, 2021 • edited Loading

loynoir commented Aug 9, 2021 • edited Loading

tuarrep commented Aug 9, 2021

JKrol commented Aug 9, 2021

muuvmuuv commented Aug 9, 2021

loynoir commented Aug 9, 2021 • edited Loading

JKrol commented Aug 9, 2021 • edited Loading

loynoir commented Aug 9, 2021 • edited Loading

duplicate slashes

loynoir commented Aug 9, 2021 • edited Loading

loynoir commented Aug 10, 2021 • edited Loading

New Browser Test Link

Test Status

gcox commented Aug 10, 2021

sindresorhus commented Aug 11, 2021

loynoir commented Aug 11, 2021 • edited Loading

loynoir commented Aug 11, 2021

New Browser Test Link

Test Status

gcox commented Aug 11, 2021

loynoir commented Aug 11, 2021 • edited Loading

gcox commented Aug 11, 2021

loynoir commented Aug 11, 2021

Aarbel commented Mar 14, 2021 •

edited

Loading

loynoir commented Aug 9, 2021 •

edited

Loading

loynoir commented Aug 9, 2021 •

edited

Loading

loynoir commented Aug 9, 2021 •

edited

Loading

JKrol commented Aug 9, 2021 •

edited

Loading

loynoir commented Aug 9, 2021 •

edited

Loading

loynoir commented Aug 9, 2021 •

edited

Loading

loynoir commented Aug 10, 2021 •

edited

Loading

loynoir commented Aug 11, 2021 •

edited

Loading

loynoir commented Aug 11, 2021 •

edited

Loading