Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix integration tests and schema refactoring #109

Merged
merged 7 commits into from
Apr 29, 2024
Merged

Conversation

shantanu73
Copy link

@shantanu73 shantanu73 commented Apr 16, 2024

Description of change

  1. Schema refactoring changes
  2. Fix integration tests to accommodate new discounts field in subscriptions schema

Manual QA steps

  • Ran tap-tester locally

Risks

  • No risk

Rollback steps

  • revert this branch

@rdeshmukh15
Copy link

rdeshmukh15 commented Apr 25, 2024

What is the schema change exactly? I can only see spacing has changed in subscriptions.json
Please keep the refactoring changes in a different PR.

@shantanu73
Copy link
Author

What is the schema change exactly? I can only see spacing has changed in subscriptions.json Please keep the refactoring changes in a different PR.

@rdeshmukh15 updated the description, you may review again.

@shantanu73 shantanu73 changed the title Update subscription schema to include manual discounts Fix integration tests and schema refactoring Apr 26, 2024
@shantanu73 shantanu73 merged commit 0b571d1 into master Apr 29, 2024
3 checks passed

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why was my comment deleted?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants