Make "module-info shell" Tcl test compatible with Lmod<=8.7.55 #682
+8
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xdelaruelle
force-pushed
the
tcl_module-info_shell
branch
from
e1a1395 to
c4e1049
Compare
vsoch
reviewed
Jan 11, 2025
shpc/settings.yml
Outdated
|
|
||
| # config editor | ||
| config_editor: vim | ||
|
|
||
| # set a default container technology (singularity or podman) | ||
| container_tech: singularity | ||
| container_tech: podman |
There was a problem hiding this comment.
You'll want to leave the defaults here as is (the container_tech and remove updated_at). Other than that, just update the version in shpc/version.py and add a corresponding note to the changelog! It's after midnight and I'm off to sleep, but I'll finish the review in the morning. Thanks for fixing this!
There was a problem hiding this comment.
My bad! the settings update is a mistake (it is too early in the morning on my side ^^).
I have fixed the commit and updated the version and changelog.
Have a good night!
xdelaruelle
force-pushed
the
tcl_module-info_shell
branch
from
c4e1049 to
75fb304
Compare
Up to Lmod 8.7.55, the Tcl command "module-info shell" only returns the
current shell name and cannot test if a given string corresponds this
current shell.
A patch is now merged on Lmod, so newer version (8.7.56+) will cope with
the "module-info shell bash" syntax.
But in the mean time, I propose here to use a test Tcl syntax that will
be compatible with both Lmod and Environment Modules: "[module-info
shell] eq {bash}".
This change may only be of help for people willing to use the Tcl
modules produced by SHPC with the Lmod module tool.
xdelaruelle
force-pushed
the
tcl_module-info_shell
branch
from
75fb304 to
8704dc4
Compare
vsoch
approved these changes
Jan 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Up to Lmod 8.7.55, the Tcl command "module-info shell" only returns the current shell name and cannot test if a given string corresponds this current shell.
A patch is now merged on Lmod, so newer version (8.7.56+) will cope with the "module-info shell bash" syntax.
But in the mean time, I propose here to use a test Tcl syntax that will be compatible with both Lmod and Environment Modules: "[module-info shell] eq {bash}".
This change may only be of help for people willing to use the Tcl modules produced by SHPC with the Lmod module tool.