Improve is-element.test.js #84
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mroderick
force-pushed
the
improve-is-element-test
branch
2 times, most recently
from
19d59be to
6a84f51
Compare
During some other work it became clear that this test does not have good isolation, ad it would fail because `is-element.js` would not detect a DOM when it was loaded as a side effect of loading `samsam` by other tests. The solution is to ensure that this test prepares the environment properly, by deleting `is-element.js` from `require.cache` and setting up a DOM, before loading `is-element.js`. See: * https://nodejs.org/api/modules.html#modules_require_cache * http://derpturkey.com/reload-module-with-node-js-require/
* Apply white space to make code easily read as Arrange, Act, Assert * Rename variable to make it clearer what it is
This improves the readability of tests because the natural reading direction of English is left to right. Readers will no longer have to scan back and forth in the first argument to `it` to figure out when this expectation applies.
mroderick
force-pushed
the
improve-is-element-test
branch
from
6a84f51 to
1399b4a
Compare
2 tasks
Codecov Report
@@ Coverage Diff @@
## master #84 +/- ##
=======================================
Coverage 98.51% 98.51%
=======================================
Files 17 17
Lines 472 472
=======================================
Hits 465 465
Misses 7 7
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes a few improvements to
is-element.test.jsPurpose (TL;DR)
Improve test isolation in order to allow future work to re-order tests.
Background
During work in #82 I discovered that this test is sensitive to load order.
Solution
is-element.jsdetects the DOM set up in the test harness.How to verify - mandatory
Checklist for author
npm run lintpasses