Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Meeting part icons aren't cached #3871

Open
3 tasks done
dagandrew opened this issue Jan 1, 2025 · 4 comments
Open
3 tasks done

[Bug]: Meeting part icons aren't cached #3871

dagandrew opened this issue Jan 1, 2025 · 4 comments
Assignees
Labels
awaiting-release Will be released with next update bug Something isn't working

Comments

@dagandrew
Copy link

dagandrew commented Jan 1, 2025

What happened?

I've noticed that if you don't have internet connection, meeting part icons won't be loaded and it looks like this
image

To Reproduce

  1. Go to '...'
  2. Click on '....'
  3. Do '....'
  4. See error

What did you expect to happen?

It would be nice to see the icons even if you don't internet. It goes here every time when the app is loaded https://wol.jw.org/assets/fonts/jw-icons-external-1970474.woff, could this be cached?

Version

24.12.12.3-beta.0

What platform are you seeing the problem on?

Windows

Relevant log output

No response

Screenshots

No response

Additional context

No response

Confirmations

  • I confirm that I have read the documentation website.
  • I confirm that I have searched through the existing issues to make sure my bug report is not a duplicate.
  • I confirm that I have searched through the existing discussions to make sure my bug report is not a duplicate.
@dagandrew dagandrew added the bug Something isn't working label Jan 1, 2025
@mtdvlpr
Copy link
Collaborator

mtdvlpr commented Jan 1, 2025

Thanks for reporting this! We do cache the fonts, but we also check if the local filesize matches the size of the remote font file, to make sure the latest version is cached. But when that call fails (because you're offline) it didn't fallback to the local file.

This has been fixed in 012713b

@mtdvlpr mtdvlpr added the awaiting-release Will be released with next update label Jan 1, 2025
@dagandrew
Copy link
Author

Could it be this way: load the local file and then check if the file is changed? I don't know what's with my connection but it takes a long time to load

@kentestaccount
Copy link

Hey! We also noticed that when there is no internet connection, the font and the 'JW' logo at the bottom right in the yeartext don't load properly. Was this also fixed?

@mtdvlpr
Copy link
Collaborator

mtdvlpr commented Jan 4, 2025

Hey! We also noticed that when there is no internet connection, the font and the 'JW' logo at the bottom right in the yeartext don't load properly. Was this also fixed?

Yes, that's the same font :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting-release Will be released with next update bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants