Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: First image zoom-in is not smooth #3873

Closed
3 tasks done
ux-git opened this issue Jan 1, 2025 · 5 comments
Closed
3 tasks done

[Bug]: First image zoom-in is not smooth #3873

ux-git opened this issue Jan 1, 2025 · 5 comments
Assignees
Labels
bug Something isn't working wontfix This will not be worked on

Comments

@ux-git
Copy link
Contributor

ux-git commented Jan 1, 2025

What happened?

The new release is awesome! When testing it I noticed that first zoom in click is quite choppy and seems like it's equal to two clicks actually.

To Reproduce

  1. Go to meeting media
  2. Click on + on any image
  3. The transition is like 0ms long and not just one + in, but more
  4. The last - step as well as 'reset' action are also instant with no transition.

What did you expect to happen?

Smooth transition and exactly +1 zoom in step

Version

v24.12.2

What platform are you seeing the problem on?

macOS

Relevant log output

No response

Screenshots

Screen.Recording.2025-01-01.at.15.40.36.mov

Additional context

No response

Confirmations

  • I confirm that I have read the documentation website.
  • I confirm that I have searched through the existing issues to make sure my bug report is not a duplicate.
  • I confirm that I have searched through the existing discussions to make sure my bug report is not a duplicate.
@ux-git ux-git added the bug Something isn't working label Jan 1, 2025
@ux-git ux-git changed the title [Bug]: First image zoom is not smooth [Bug]: First image zoom-in is not smooth Jan 1, 2025
@mtdvlpr
Copy link
Collaborator

mtdvlpr commented Jan 10, 2025

I see what you mean, but there's little we can do about it. Besides, the transition on the media window is always smooth, so I don't think it matters much.

@ux-git
Copy link
Contributor Author

ux-git commented Jan 10, 2025

I agree regarding the smooth animation on the media preview screen, but as I recall, in earlier versions there was no such issue. The jumpy animation is not a huge deal breaker but perhaps you could fix the first zoom in (+ button) click being actually two steps in zooming in? All further coming steps are consistent, only the first click behaves like this.

Also, does initiation of zooming with a mouse wheel works on your Windows computer? Or should users now click + button to start zooming in?

@mtdvlpr
Copy link
Collaborator

mtdvlpr commented Jan 11, 2025

Each step is configured to be a 0.2 zoom factor and you go from 1 which is the default to 5 which is the maximum zoom.

A 0.2 zoom factor means each step increases the zoom by (5 - 1) * 0.2 = 0.8. So the steps are: 1, 1.8, 2.6, 3.4, 4.2, 5.

Zooming from 1 to 1.8 is almost double, while 4.2 to 5 is a lot less relatively speaking. That's why the first step feels bigger than the other steps. The same happens when you zoom in your browser using the same factor (0 -> 20% -> 40% -> 60% -> 80% - 100%). The first zoom will feel much bigger than the last.

To solve that we'd have to use some sort of formula to base the zoom factor on the current zoom level.

I have no idea why the animation would be missing. We're using a package for the zoom functionality, so it might be a bug in their code.

Zooming with a mouse is currently enabled after the first zoom is done manually. This is to enable dragging the media by the thumbnail for sorting. That was discussed in #3822.

@ux-git
Copy link
Contributor Author

ux-git commented Jan 12, 2025

Got it 👌

@ux-git ux-git closed this as not planned Won't fix, can't repro, duplicate, stale Jan 12, 2025
@mtdvlpr mtdvlpr added the wontfix This will not be worked on label Jan 13, 2025
@ux-git
Copy link
Contributor Author

ux-git commented Jan 16, 2025

Hmm, the first zoom in besides being too close, is also not centered. Now, having only the option to click + (no wheel scrolling to the desired point anymore), this creates a little trouble every time an image has to be zoomed in.

@mtdvlpr this is the first zoom in step:
Screenshot 2025-01-16 at 10 11 51

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

3 participants