-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug]: First image zoom-in is not smooth #3873
Comments
I see what you mean, but there's little we can do about it. Besides, the transition on the media window is always smooth, so I don't think it matters much. |
I agree regarding the smooth animation on the media preview screen, but as I recall, in earlier versions there was no such issue. The jumpy animation is not a huge deal breaker but perhaps you could fix the first zoom in (+ button) click being actually two steps in zooming in? All further coming steps are consistent, only the first click behaves like this. Also, does initiation of zooming with a mouse wheel works on your Windows computer? Or should users now click + button to start zooming in? |
Each step is configured to be a 0.2 zoom factor and you go from 1 which is the default to 5 which is the maximum zoom. A 0.2 zoom factor means each step increases the zoom by (5 - 1) * 0.2 = 0.8. So the steps are: 1, 1.8, 2.6, 3.4, 4.2, 5. Zooming from 1 to 1.8 is almost double, while 4.2 to 5 is a lot less relatively speaking. That's why the first step feels bigger than the other steps. The same happens when you zoom in your browser using the same factor (0 -> 20% -> 40% -> 60% -> 80% - 100%). The first zoom will feel much bigger than the last. To solve that we'd have to use some sort of formula to base the zoom factor on the current zoom level. I have no idea why the animation would be missing. We're using a package for the zoom functionality, so it might be a bug in their code. Zooming with a mouse is currently enabled after the first zoom is done manually. This is to enable dragging the media by the thumbnail for sorting. That was discussed in #3822. |
Got it 👌 |
Hmm, the first zoom in besides being too close, is also not centered. Now, having only the option to click + (no wheel scrolling to the desired point anymore), this creates a little trouble every time an image has to be zoomed in. @mtdvlpr this is the first zoom in step: |
What happened?
The new release is awesome! When testing it I noticed that first zoom in click is quite choppy and seems like it's equal to two clicks actually.
To Reproduce
What did you expect to happen?
Smooth transition and exactly +1 zoom in step
Version
v24.12.2
What platform are you seeing the problem on?
macOS
Relevant log output
No response
Screenshots
Screen.Recording.2025-01-01.at.15.40.36.mov
Additional context
No response
Confirmations
The text was updated successfully, but these errors were encountered: