Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[feature/no-ref/separate-rvo2] Enhance overall performance by eliminating global variables #45

Open
tashakim opened this issue Jan 25, 2024 · 1 comment
Open

[feature/no-ref/separate-rvo2] Enhance overall performance by eliminating global variables #45

tashakim opened this issue Jan 25, 2024 · 1 comment
Labels
refactor

Comments

@tashakim
Copy link
Collaborator

There is extensive use of, and reliance on, global variables throughout the codebase, which is known to degrade performance of Julia.

All instances of globally loaded variables should be replaced by using structs to specify config etc. or some other strategy.

Important: The performance enhancement should be be measured, compared, and verified using @time (or similar).
@tashakim tashakim added the bug Something isn't working label Jan 25, 2024
tashakim added a commit that referenced this issue Jan 30, 2024
@tashakim
Remove unused avoid_staging_area global variable
9f5fb14 
This CL removes the declaration of the variable `avoid_staging_areas`
from route_planning, and removes the call to set this from full_demo.
Note no other scripts refer to this variable, and current route planning
logic does not use it.

Bug: #45, #39
Test: Passes all tests
Test Summary:          | Pass  Total     Time
ConstructionBots Tests |   15     15  3m48.2s
     Testing ConstructionBots tests passed
@tashakim tashakim added refactor and removed bug Something isn't working labels Feb 26, 2024
@tashakim
Copy link
Collaborator Author

WIP: See commits b2b023a, 2a98af2, bf6145a

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
refactor
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tashakim