Replace flake8 with ruff #243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It fixed a bunch of unnecessary imports in .pyi files too!
It rewrites the .pyi files to use more modern syntax.
It's the equivalent of yesqa (warns about useless noqa).
It does additional .pyi files checks. Mostly the fixes are just stylistic, but it did pick up incorrect typing on the `__iadd__` return type (only noticeable if you actually call it as `__iadd__`, since `+=` is a statement not an expression.
| @@ -112,7 +98,7 @@ class MemoryPool(MemoryAllocator): | |||
| upper: int, | |||
| max_free: int, | |||
| initial: int, | |||
| allocator: Optional[MemoryAllocator] = None, | |||
| allocator: MemoryAllocator | None = None, | |||
There was a problem hiding this comment.
My only concern is that this kind of change will break backwards compatibility. Unless for new versions of spead2 you are only planning on supporting Python 3.10+?
There was a problem hiding this comment.
When I saw that ruff had made these changes my first thought was it was a bug, since I've told it to be 3.8-compatible. But this is a .pyi file, so it's only interpreted by type checkers and not the actual Python runtime.
There was a problem hiding this comment.
Ah, that makes sense.
james-smith-za
approved these changes
Aug 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I also enabled a few extra plugins beyond the flake8 basics, and fixed resulting errors.