Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ticket-1620 fixed misprint in event log scanner code #1625

Merged
merged 2 commits into from
Oct 31, 2023

Conversation

sergiy-skalelabs
Copy link
Contributor

Fixed misprint in event log scanner code. No new tests needed. We must re-check it in legacy network also.

@codecov
Copy link

codecov bot commented Oct 28, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (21c1e96) 85.79% compared to head (47db2ff) 85.79%.

❗ Current head 47db2ff differs from pull request most recent head 8f3eae9. Consider uploading reports for the commit 8f3eae9 to get more accurate results

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1625   +/-   ##
========================================
  Coverage    85.79%   85.79%           
========================================
  Files           26       26           
  Lines         1464     1464           
  Branches       401      401           
========================================
  Hits          1256     1256           
  Misses          33       33           
  Partials       175      175           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@DmytroNazarenko DmytroNazarenko marked this pull request as ready for review October 30, 2023 20:42
@DmytroNazarenko DmytroNazarenko merged commit 36252ff into develop Oct 31, 2023
16 of 17 checks passed
@DmytroNazarenko DmytroNazarenko deleted the ticket-1620/fix-event-log-scanner branch October 31, 2023 15:17
@github-actions github-actions bot locked and limited conversation to collaborators Oct 31, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

IMA: getPastEvents sometimes work significantly slow as expected
2 participants