Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ticket 1620/rollback event log scanner #1631

Merged
merged 5 commits into from
Oct 31, 2023

Conversation

sergiy-skalelabs
Copy link
Contributor

Merge logging imporvements

Copy link

codecov bot commented Oct 31, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (1f2459f) 85.79% compared to head (3ed576d) 85.79%.

❗ Current head 3ed576d differs from pull request most recent head 0d63e3e. Consider uploading reports for the commit 0d63e3e to get more accurate results

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1631   +/-   ##
========================================
  Coverage    85.79%   85.79%           
========================================
  Files           26       26           
  Lines         1464     1464           
  Branches       401      401           
========================================
  Hits          1256     1256           
  Misses          33       33           
  Partials       175      175           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@DmytroNazarenko DmytroNazarenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typos should be fixed

npms/skale-ima/index.mjs Outdated Show resolved Hide resolved
npms/skale-ima/index.mjs Show resolved Hide resolved
npms/skale-ima/index.mjs Outdated Show resolved Hide resolved
npms/skale-ima/index.mjs Show resolved Hide resolved
@sergiy-skalelabs sergiy-skalelabs marked this pull request as ready for review October 31, 2023 18:04
@sergiy-skalelabs sergiy-skalelabs merged commit 17a59ef into develop Oct 31, 2023
15 checks passed
@sergiy-skalelabs sergiy-skalelabs deleted the ticket-1620/rollback-event-log-scanner branch October 31, 2023 21:29
@github-actions github-actions bot locked and limited conversation to collaborators Oct 31, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

IMA: getPastEvents sometimes work significantly slow as expected
3 participants