Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed auth support in URLs #1644

Merged
merged 3 commits into from
Nov 30, 2023
Merged

Fixed auth support in URLs #1644

merged 3 commits into from
Nov 30, 2023

Conversation

sergiy-skalelabs
Copy link
Contributor

Fixed auth support in URLs
No performance changes
No new tests needed

Copy link

codecov bot commented Nov 29, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (5229b42) 85.79% compared to head (c6794b0) 85.79%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1644   +/-   ##
========================================
  Coverage    85.79%   85.79%           
========================================
  Files           26       26           
  Lines         1464     1464           
  Branches       401      401           
========================================
  Hits          1256     1256           
  Misses          33       33           
  Partials       175      175           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sergiy-skalelabs sergiy-skalelabs linked an issue Nov 30, 2023 that may be closed by this pull request
badrogger
badrogger previously approved these changes Nov 30, 2023
@DmytroNazarenko DmytroNazarenko merged commit 1b2884e into develop Nov 30, 2023
17 checks passed
@DmytroNazarenko DmytroNazarenko deleted the hotfix-support-url-auth branch November 30, 2023 13:32
@github-actions github-actions bot locked and limited conversation to collaborators Nov 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix ethers v5 problem with in-URL auth
3 participants